Document automatic registration of extension compiler passes#5920
Closed
wouterj wants to merge 2 commits intosymfony:2.8from
Closed
Document automatic registration of extension compiler passes#5920wouterj wants to merge 2 commits intosymfony:2.8from
wouterj wants to merge 2 commits intosymfony:2.8from
Conversation
Member
wouterj
commented
Nov 28, 2015
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes (symfony/symfony#13761) |
| Applies to | 2.8+ |
| Fixed tickets | - |
Contributor
There was a problem hiding this comment.
This one is needed (used in process)
Member
Author
There was a problem hiding this comment.
Yeah, but we already added it in this file above and it's "included" in the // ... on line 320.
07db233 to
d0e971d
Compare
Member
There was a problem hiding this comment.
We should also add a label for the old headline.
Member
There was a problem hiding this comment.
Practically -> In practice ?
Member
Author
|
Thanks for the detailed review guys, I've applied the comments. |
bf740fb to
d429442
Compare
Member
Author
|
Fixed |
Member
|
👍 |
wouterj
added a commit
that referenced
this pull request
Feb 6, 2016
…asses (WouterJ) This PR was squashed before being merged into the 2.8 branch (closes #5920). Discussion ---------- Document automatic registration of extension compiler passes | Q | A | --- | --- | Doc fix? | no | New docs? | yes (symfony/symfony#13761) | Applies to | 2.8+ | Fixed tickets | - Commits ------- 353df25 Document automatic registration of extension compiler passes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.