Skip to content

[2.8] Add "How to Use Multiple Guard Authenticators" cookbook documentation#5886

Closed
marek-pietrzak-tg wants to merge 6 commits intosymfony:2.8from
marek-pietrzak-tg:use_different_entry_points
Closed

[2.8] Add "How to Use Multiple Guard Authenticators" cookbook documentation#5886
marek-pietrzak-tg wants to merge 6 commits intosymfony:2.8from
marek-pietrzak-tg:use_different_entry_points

Conversation

@marek-pietrzak-tg
Copy link
Copy Markdown
Contributor

Q A
Doc fix? no
New docs? yes (symfony/symfony#14673)
Applies to 2.8 onwards

Hi guys,
this is my first contribution to the symfony docs.
During my preparations for the Symfony Guard component workshops I have spent some time trying to figure out the problem described here.
I hope this cookbook entry will help others save their time.

cc @weaverryan

Thanks!

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing empty line before this line

@marek-pietrzak-tg
Copy link
Copy Markdown
Contributor Author

Any thoughts on this?

How to Use Multiple Guard Authenticators
========================================

Guard authentication component allows you to easily use many different authenticators at a time.
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Guard [...]

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Feb 9, 2016

I am really sorry that we missed to review your pull request for such a long time @mheki! This looks really great and I just left you some minor comments.

<!-- ... -->
<firewall name="default">
<anonymous />
<guard entry_point="app.form_login_authenticator">
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be entry-point (XML conventions are to not use underscores and the XmlFileLoader takes care of transforming all dashes into underscores)

@marek-pietrzak-tg
Copy link
Copy Markdown
Contributor Author

Thanks for the review @xabbuh @wouterj I've changed the docs according to your suggestions.
Could you take a look again please?

@wouterj
Copy link
Copy Markdown
Member

wouterj commented Feb 10, 2016

Looks great, thanks for submitting the docs and your quick response @mheki! 👍

I think we should add a .. versionadded:: directive indicating Guard was added in 2.8 directly after the headline, but we can add this after the merge.

@marek-pietrzak-tg
Copy link
Copy Markdown
Contributor Author

Hmmm... I've just seen your commit Removed all 2.x versionadded directives made couple days ago...

@wouterj
Copy link
Copy Markdown
Member

wouterj commented Feb 10, 2016

@mheki yeah, for the 3.0 + master branch. I think it still makes sense for the 2.8 branch.

@marek-pietrzak-tg marek-pietrzak-tg force-pushed the use_different_entry_points branch from d41c659 to a2ca764 Compare February 10, 2016 12:42
@marek-pietrzak-tg
Copy link
Copy Markdown
Contributor Author

👍 added versionadded

@wouterj
Copy link
Copy Markdown
Member

wouterj commented Feb 10, 2016

Nice, thanks! :)

xabbuh added a commit that referenced this pull request Feb 10, 2016
…okbook documentation (mheki)

This PR was squashed before being merged into the 2.8 branch (closes #5886).

Discussion
----------

[2.8] Add "How to Use Multiple Guard Authenticators" cookbook documentation

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes (symfony/symfony#14673)
| Applies to    | `2.8` onwards

Hi guys,
this is my first contribution to the symfony docs.
During my preparations for the Symfony Guard component workshops I have spent some time trying to figure out the problem described here.
I hope this cookbook entry will help others save their time.

cc @weaverryan

Thanks!

Commits
-------

121196d [2.8] Add "How to Use Multiple Guard Authenticators" cookbook documentation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants