HTML5 range documentation#5458
Conversation
reference/forms/types/range.rst
Outdated
There was a problem hiding this comment.
Hm. Anyone have idea how many spaces should be kept ?
There was a problem hiding this comment.
You need one more in this and in the next line (have a look at the right most | character).
There was a problem hiding this comment.
By the way, min and max are no options of the form type. You need to pass them as attr option keys.
There was a problem hiding this comment.
may be we need attr here.
|
Hey @xabbuh , Thanks for all the comments. What about the examples ? |
|
I think a simple example showing how to configure the |
|
Hey @xabbuh , May be I didn't explained better regarding what I was referencing to. Basically if you check the markdown of http://symfony.com/doc/current/reference/forms/types/number.html ( https://raw.githubusercontent.com/harikt/symfony-docs/range/reference/forms/types/number.rst ) , you can see the I will make the changes and get back. Thank you. |
reference/forms/types/range.rst
Outdated
There was a problem hiding this comment.
Please add a code-block directive before the example code:
.. code-block:: php
$builder->add('name', 'range', array(|
The new range documentation isn't included anywhere yet. I found these small issues by testing the documentation first on my local machine: |
reference/forms/types/range.rst
Outdated
There was a problem hiding this comment.
This description should be moved before the mapped option's description.
|
Very great @harikt. I left you one minor comment. After that I think this looks ready to be merged. |
|
@xabbuh done 👍 . Thank you. |
|
👍 |
|
@harikt! This is wonderful! I have no changes - and now I can also close the related issue :). Thanks! |
This PR was merged into the 2.8 branch. Discussion ---------- HTML5 range documentation Hi, | Q | A | ------------- | --- | Doc fix? | yes | New feature? | yes | BC breaks? | no | Deprecations? | no | Fixed tickets | [#5439] | Code PR | [12607] | License | MIT I am trying to contribute to range added for the PR symfony/symfony#12067 & symfony/symfony#11979 which fixes #5439 . Need some help on moving for I am really new to the documentation. The current issues I feel is whether we need to add Basic usage or is that only reference ? I had a look at http://symfony.com/doc/current/reference/forms/types/number.html which would have been similar, but that seems it referencing to choice seems more confusing. I have looked into other types also and almost all are some what similar. Any input is highly appreciated and will work on in the free time. If someone is interested please do take the PR or finish it . Thank you. Commits ------- 2863079 Fix moving the mapped down as per @xabbuh abf3e8e Fix the rendering issue 3c6ff76 Fix issues reported by @snoek09 . Thank you. a2c3f21 Make the necessary changes mentioned by @xabbuh and add example for form d4d1f12 Starting with range documentation
|
cool. Thank you all. |
Hi,
I am trying to contribute to range added for the PR symfony/symfony#12067 & symfony/symfony#11979 which fixes #5439 .
Need some help on moving for I am really new to the documentation.
The current issues I feel is whether we need to add Basic usage or is that only reference ?
I had a look at http://symfony.com/doc/current/reference/forms/types/number.html which would have been similar, but that seems it referencing to choice seems more confusing.
I have looked into other types also and almost all are some what similar.
Any input is highly appreciated and will work on in the free time. If someone is interested please do take the PR or finish it .
Thank you.