Reviewed Configuration cookbook articles#5098
Merged
weaverryan merged 3 commits intosymfony:2.3from Apr 15, 2015
Merged
Conversation
Member
javiereguiluz
commented
Mar 19, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | - |
Member
There was a problem hiding this comment.
The ApacheUrlMatcher as well as the ApacheMatcherDumper are deprecated. Should we add warning about this?
Contributor
There was a problem hiding this comment.
Yea, I think we should - I think this whole "article" is deprecated
Member
Author
There was a problem hiding this comment.
I've added a note about not using Apache Router in aedaccd. Please tell me if it's OK. Thanks.
Member
There was a problem hiding this comment.
ah, see now. For consistency, I would prefer override-web-dir
Member
Author
There was a problem hiding this comment.
Good point! I've updated the reference name. Thanks.
Contributor
There was a problem hiding this comment.
This should be Greet, correct? To match the _controller above?
weaverryan
added a commit
that referenced
this pull request
Apr 15, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Reviewed Configuration cookbook articles | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- aedaccd Added a note against using the Apache Router 2feb801 Implemented all the changes suggested by reviewers 9f49497 Reviewed Configuration cookbook articles
Contributor
|
Thanks for all the re-reads Javier - I think it's very helpful! |
weaverryan
added a commit
that referenced
this pull request
Apr 15, 2015
* 2.3: [#5098] Minor fix so controller in dumped apache matches _controller route information above fix code block order Update process.rst [Cookbook] Add warning about Composer dev deps on Heroku Added a note against using the Apache Router Implemented all the changes suggested by reviewers Minor rewording Reviewed Configuration cookbook articles Reviewed Cache cookbook articles
weaverryan
added a commit
that referenced
this pull request
Apr 15, 2015
* 2.6: [#5098] Minor fix so controller in dumped apache matches _controller route information above fix code block order Update process.rst [Cookbook] Add warning about Composer dev deps on Heroku Added a note against using the Apache Router Implemented all the changes suggested by reviewers Minor rewording Reviewed Configuration cookbook articles Reviewed Cache cookbook articles
weaverryan
added a commit
that referenced
this pull request
Apr 15, 2015
* 2.8: [#5098] Minor fix so controller in dumped apache matches _controller route information above fix code block order Update process.rst [Cookbook] Add warning about Composer dev deps on Heroku Added a note against using the Apache Router Implemented all the changes suggested by reviewers Minor rewording Reviewed Configuration cookbook articles Reviewed Cache cookbook articles
javiereguiluz
pushed a commit
to javiereguiluz/symfony-docs
that referenced
this pull request
Sep 2, 2015
…roller route information above
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.