Reviewed the Assetic cookbook articles#5094
Merged
weaverryan merged 2 commits intosymfony:2.3from Mar 22, 2015
Merged
Conversation
Member
javiereguiluz
commented
Mar 19, 2015
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| Applies to | all |
| Fixed tickets | - |
cookbook/assetic/uglifyjs.rst
Outdated
Member
There was a problem hiding this comment.
for windows compatbility, the path should be in double quotes
Member
Author
There was a problem hiding this comment.
You mean like this?
$ "./app/Resources/node_modules/.bin/uglifyjs" --help
Member
There was a problem hiding this comment.
yes
2015-03-19 11:41 GMT+01:00 Javier Eguiluz notifications@github.com:
In cookbook/assetic/uglifyjs.rst
#5094 (comment):
- $ uglifyjs --help
+Now you can execute theuglifyjscommand that lives in thenode_modules
+directory:
+.. code-block:: bash
$ ./app/Resources/node_modules/.bin/uglifyjs --help
You mean like this?
$ "./app/Resources/node_modules/.bin/uglifyjs" --help
—
Reply to this email directly or view it on GitHub
https://github.com/symfony/symfony-docs/pull/5094/files#r26743251.
Member
|
👍 |
Member
There was a problem hiding this comment.
Not sure about this change. While I agree that "frontend" looks most beautiful, it seems that "front-end" actually would be more correct (see also #4671 (comment)).
Contributor
There was a problem hiding this comment.
both Bower and Bootstrap (on their homepages) use front-end. That looks a bit odd to me, but I guess we should follow their lead.
weaverryan
added a commit
that referenced
this pull request
Mar 22, 2015
Contributor
weaverryan
added a commit
that referenced
this pull request
Mar 24, 2015
* 2.3: (44 commits) Removed duplicate "long"s terminate file with newline move title back and move description to separate file as suggested in PR #4892 move title out of included file as suggested in PR #4892 Add possible values for widget_type [#4842] Making 2 sentences changes as suggested by WouterJ in pull request #4842 Add meaning of yellow icon for number of queries Fixing bad link name fix typo in event flow diagrams Many fixes thanks to stof, WouterJ, xabbuh and dupuchba added Jakub as a merger for the DomCrawler component [#5094] Removing mkdir - it's not needed (thanks xabbuh) some tweaks to #4601 Moving index down to correct section [#4989] Language tweaks and making the example simpler Remove useless setLocale() call and add code block with locale setter Finaly touches on translation locale setting note Review note about setting the translator locale in a controller. Update translation.rst ... Conflicts: cookbook/security/entity_provider.rst
weaverryan
added a commit
that referenced
this pull request
Mar 24, 2015
* 2.6: (45 commits) Removed duplicate "long"s terminate file with newline move title back and move description to separate file as suggested in PR #4892 move title out of included file as suggested in PR #4892 Add possible values for widget_type [#4842] Making 2 sentences changes as suggested by WouterJ in pull request #4842 Add meaning of yellow icon for number of queries Fixing bad link name fix typo in event flow diagrams Many fixes thanks to stof, WouterJ, xabbuh and dupuchba added Jakub as a merger for the DomCrawler component [#5094] Removing mkdir - it's not needed (thanks xabbuh) some tweaks to #4601 Moving index down to correct section [#4989] Language tweaks and making the example simpler Remove useless setLocale() call and add code block with locale setter Finaly touches on translation locale setting note Review note about setting the translator locale in a controller. Update translation.rst ...
weaverryan
added a commit
that referenced
this pull request
Mar 24, 2015
* 2.7: (47 commits) Removed duplicate "long"s terminate file with newline move title back and move description to separate file as suggested in PR #4892 move title out of included file as suggested in PR #4892 Add possible values for widget_type [#4842] Making 2 sentences changes as suggested by WouterJ in pull request #4842 Add meaning of yellow icon for number of queries Fixing bad link name fix typo in event flow diagrams Many fixes thanks to stof, WouterJ, xabbuh and dupuchba added Jakub as a merger for the DomCrawler component Changes thanks to WouterJ and xabbuh [#5094] Removing mkdir - it's not needed (thanks xabbuh) some tweaks to #4601 Moving index down to correct section [#4989] Language tweaks and making the example simpler Remove useless setLocale() call and add code block with locale setter Finaly touches on translation locale setting note Review note about setting the translator locale in a controller. ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.