Removed no longer needed information about PHP 5.3#4854
Merged
weaverryan merged 1 commit intosymfony:2.3from Feb 24, 2015
Merged
Removed no longer needed information about PHP 5.3#4854weaverryan merged 1 commit intosymfony:2.3from
weaverryan merged 1 commit intosymfony:2.3from
Conversation
Member
There was a problem hiding this comment.
I think you can also remove the comma in front of the "and".
Member
Author
There was a problem hiding this comment.
I'm not entirely sure about this one. I think it's valid here to difference that this list is not "A, B or C", but instead "A, B or C, and D".
Contributor
There was a problem hiding this comment.
my "gut feeling" is that I agree with Wouter - it helps give the sentence some separation/pause. Is "gut feeling" good enough? ;)
Contributor
|
Yep, very very good idea. Not all things we say need to be there forever - it's cool how "new" things become commonplace. Thanks! |
weaverryan
added a commit
that referenced
this pull request
Feb 24, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Removed no longer needed information about PHP 5.3 While merging, #4753, I thought we could remove these things completely from the docs, as PHP 5.3 and namespacing are quite common now. | Q | A | --- | --- | Doc fix? | yes | New docs? | no | Applies to | all | Fixed tickets | - Commits ------- b6636ae Removed no longer needed information about PHP 5.3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While merging, #4753, I thought we could remove these things completely from the docs, as PHP 5.3 and namespacing are quite common now.