Skip to content

[Reference] add validation config reference section#4673

Merged
weaverryan merged 1 commit intosymfony:2.3from
xabbuh:issue-4094-reference
Dec 29, 2014
Merged

[Reference] add validation config reference section#4673
weaverryan merged 1 commit intosymfony:2.3from
xabbuh:issue-4094-reference

Conversation

@xabbuh
Copy link
Copy Markdown
Member

@xabbuh xabbuh commented Dec 20, 2014

Q A
Doc fix? yes
New docs? no
Applies to all
Fixed tickets

@xabbuh xabbuh force-pushed the issue-4094-reference branch 3 times, most recently from 2b38a28 to 88df04a Compare December 20, 2014 23:02
@xabbuh xabbuh force-pushed the issue-4094-reference branch from 88df04a to cdb4284 Compare December 22, 2014 11:17
weaverryan
weaverryan reviewed Dec 22, 2014
View reviewed changes
reference/configuration/framework.rst Outdated
Copy link
Copy Markdown
Contributor

@weaverryan weaverryan Dec 22, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this was added in 2.5: https://github.com/symfony/symfony/blob/2.3/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php#L375

Copy link
Copy Markdown
Member Author

@xabbuh xabbuh Dec 23, 2014

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, Ryan. I'll remove it here and add it again when creating the pull request for the api option.

@weaverryan
Copy link
Copy Markdown
Contributor

weaverryan commented Dec 22, 2014

I left a few comments, but nice catch on this being missing! It looks like several other options are introduced in 2.5 (and maybe also 2.6) - including the very-important api version for 2.5.

Thanks!

@xabbuh
Copy link
Copy Markdown
Member Author

xabbuh commented Dec 23, 2014

I left a few comments, but nice catch on this being missing! It looks like several other options are introduced in 2.5 (and maybe also 2.6) - including the very-important api version for 2.5.

Honestly, I just caught this when I wanted to document the api option and then decided to add the whole section first.

@xabbuh xabbuh force-pushed the issue-4094-reference branch from cdb4284 to 2a084c9 Compare December 23, 2014 21:35
@xabbuh xabbuh force-pushed the issue-4094-reference branch from 2a084c9 to 79ad3b5 Compare December 23, 2014 21:39
@xabbuh xabbuh mentioned this pull request Dec 23, 2014
Merged
@xabbuh
Copy link
Copy Markdown
Member Author

xabbuh commented Dec 23, 2014

I moved the 2.5 specific parts into a new pull request (see #4682).

@xabbuh xabbuh mentioned this pull request Dec 29, 2014
Merged
@weaverryan
Copy link
Copy Markdown
Contributor

weaverryan commented Dec 29, 2014

Thanks for the quick work! Now I'll go check the other PR :)

@weaverryan weaverryan merged commit 79ad3b5 into symfony:2.3 Dec 29, 2014
weaverryan added a commit that referenced this pull request Dec 29, 2014
@weaverryan
feature #4673 [Reference] add validation config reference section (xa…
bd65c3c 
…bbuh)

This PR was merged into the 2.3 branch.

Discussion
----------

[Reference] add validation config reference section

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets |

Commits
-------

79ad3b5 add validation config reference section
@xabbuh xabbuh deleted the issue-4094-reference branch December 29, 2014 18:38
@xabbuh xabbuh mentioned this pull request Dec 29, 2014
Merged
wouterj added a commit that referenced this pull request Dec 31, 2014
@wouterj
minor #4709 [Reference] fix wording (xabbuh)
8bd694f 
This PR was merged into the 2.3 branch.

Discussion
----------

[Reference] fix wording

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4673

Commits
-------

10b06da [Reference] fix wording
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Status: Reviewed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@xabbuh @weaverryan @wouterj