Added '-ing' title ending to unify titles look#4625
Closed
kix wants to merge 1 commit intosymfony:2.6from
Closed
Conversation
Member
|
👍 Why not? Consistency is always nice in the docs. @kix We need however take into account that someone might already refer to the old headline. Therefore we should add a label to keep the old anchor working. Can you please add one just before the headline? It would basically then look like this ("are" should actually be capitalised too): .. _understand-how-console-arguments-are-handled:
Understanding how Console Arguments Are Handled
=============================================== |
Currently all of the titles in Console section use gerund, but not this one.
Contributor
Author
|
@xabbuh, 👍 |
Member
|
Thanks @kix |
weaverryan
added a commit
that referenced
this pull request
Dec 11, 2014
weaverryan
added a commit
that referenced
this pull request
Dec 11, 2014
* 2.3: [#4625] Removing link added for BC, because this is the top of the page anyways Added '-ing' title ending to unify titles look [OptionsResolver] Fix Namespace link filesystem headlines match method names Change refering block name from content to body When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value. Fixing missing services key readd mistakenly removed label fix feature freeze dates Conflicts: best_practices/security.rst
weaverryan
added a commit
that referenced
this pull request
Dec 11, 2014
* 2.5: [#4625] Removing link added for BC, because this is the top of the page anyways Added '-ing' title ending to unify titles look [OptionsResolver] Fix Namespace link filesystem headlines match method names Change refering block name from content to body When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value. Fixing missing services key readd mistakenly removed label fix feature freeze dates Conflicts: components/options_resolver.rst
weaverryan
added a commit
that referenced
this pull request
Dec 11, 2014
* 2.7: [#4625] Removing link added for BC, because this is the top of the page anyways Added '-ing' title ending to unify titles look [OptionsResolver] Fix namespace [OptionsResolver] Fix Namespace link filesystem headlines match method names Change refering block name from content to body Update pdo_session_storage.rst When explaining how to install dependencies for running unit tests, there are references to "--dev" composer parameter that is the current default value. Fixing missing services key readd mistakenly removed label fix feature freeze dates
Contributor
Member
|
@weaverryan That's true for now. But what if we decide to move that section further down in the future? |
Contributor
|
That seems unlikely - it's the title of the whole article :). Probably, if you linked to it, you really mean to just link to the whole article. |
Member
|
Btw, the title doesn't even have a link anchor next to it. So it isn't obvious for people to know that you can reference the title. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently all of the titles in Console section use gerund, but not this one.