[Console] Fix Console QuestionHelper $app to $this#3952
[Console] Fix Console QuestionHelper $app to $this#3952eko wants to merge 1 commit intosymfony:masterfrom
Conversation
|
true although you could have gotten the $app from $app = $this->getApplication(), also notice that $this->getApplication() is tagged @api so it is here to stay. But yeah this is a 👍 |
|
👍 we never told what the However, maybe changing it to |
Fix getHelperSet() to getHelper() Typo fix Move getHelperSet() to getHelper() in other files
|
Yes, it was confusing. I've updated the PR to use |
|
👍 |
|
Hi guys! Yes, this is much better. But, I need your help! Most of these changes apply to all versions (back to 2.3), but some (
@eko Can you help out with this? Thanks! |
|
Hi @weaverryan, Alright, I will create 2 new PRs against 2.3 and 2.5 branches in the week-end. Thank you |
|
Thanks @eko! |
|
Hi @weaverryan, I've sent the 2 PRs against 2.3 and 2.5 branches:
So I think this PR can be closed? Thank you |
…getHelper() (eko)
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] Fix Console component getHelperSet()->get() to getHelper()
| Q | A |
| ---------------- |:---------:|
| Doc fix? | Yes |
| New docs? | No |
| Applies to | 2.3 |
| Fixed tickets | No |
On Console component, I've fixed the following calls:
```php
$this->getHelperSet()->get('dialog');
```
to:
```php
$this->getHelper('dialog');
```
This is related to original PR #3952
Commits
-------
9207f68 [Console] Fix Console component getHelperSet()->get() to getHelper()
…getHelper() method (eko)
This PR was merged into the 2.5 branch.
Discussion
----------
[Console] Fix Console component $app to $this and use of getHelper() method
| Q | A |
| ---------------- |:---------:|
| Doc fix? | Yes |
| New docs? | No |
| Applies to | 2.5 |
| Fixed tickets | No |
On Console component, I've fixed the following:
### Use of getHelper() method
```php
$this->getHelperSet()->get('dialog');
```
to:
```php
$this->getHelper('dialog');
```
### Also fixed unusued $app variable to $this
This is related to original PR #3952
Commits
-------
1f4dc76 [Console] Fix Console some $app to $this and getHelperSet()->get() to getHelper()
On
QuestionHelperpage, commands examples for callinggetHelperSetuse the following (where $app is undefined):I've changed it to correct: