Dynamic form modification cookbook: Fix inclusion of code #3698
Merged
weaverryan merged 2 commits intosymfony:2.3from Mar 20, 2014
Merged
Dynamic form modification cookbook: Fix inclusion of code #3698weaverryan merged 2 commits intosymfony:2.3from
weaverryan merged 2 commits intosymfony:2.3from
Conversation
added 2 commits
March 20, 2014 14:51
Includes in a code block don't work, replace them with the actual code
Contributor
|
Hmm, very unfortunate indeed, but nice catch and thanks for looking into this further Michaël. I guess we'll have to be ok with this little bit of duplication - we have a lot of people keeping an eye out for not forgetting to change everything needed :). Thanks! |
weaverryan
added a commit
that referenced
this pull request
Mar 20, 2014
… (michaelperrin) This PR was merged into the 2.3 branch. Discussion ---------- Dynamic form modification cookbook: Fix inclusion of code Unfortunately, reStructuredText doesn't support inclusion of code inside a code block, resulting to non-interpreted code (the `include` keyword is not displayed) as it happens on http://symfony.com/doc/2.3/cookbook/form/dynamic_form_modification.html . I tried in many ways to avoid this, but didn't find any nice way. I had to duplicate code instead. The PR includes a few minor fixes on code style as well. Commits ------- 1e8b0d4 Small fixes in code style 8093719 Dynamic form modification cookbook: Fix inclusion of code
Contributor
Author
|
Yes indeed, I didn't like to have to duplicate code. That will be alright thanks to the active community! |
weaverryan
added a commit
that referenced
this pull request
Mar 24, 2014
This PR was merged into the 2.3 branch. Discussion ---------- Fix PSR coding standards error | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3 | Fixed tickets | Commits ------- da2ee60 Fix PSR coding standards error 868de1e minor #3698 Dynamic form modification cookbook: Fix inclusion of code (michaelperrin) acf255d feature #3328 [WIP] Travis integration (WouterJ) 5d99d88 [#3697] Backporting 2.3-specific changes 1e8b0d4 Small fixes in code style 8093719 Dynamic form modification cookbook: Fix inclusion of code 37eb137 Update documentation 8dec729 sparse checkouts b6f693e Added CMF b1d9e62 Revert changes 6cad008 Updated travis config c515613 Added .gitignore 85b1b02 Try to supress bundle doc warnings f3cb8b1 Fixed submodules 71a2ff4 Added needed config files d312683 Added sphinx files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unfortunately, reStructuredText doesn't support inclusion of code inside a code block, resulting to non-interpreted code (the
includekeyword is not displayed) as it happens on http://symfony.com/doc/2.3/cookbook/form/dynamic_form_modification.html .I tried in many ways to avoid this, but didn't find any nice way. I had to duplicate code instead.
The PR includes a few minor fixes on code style as well.