[Console] Added standalone PSR-3 compliant logger#3696
Merged
weaverryan merged 1 commit intosymfony:masterfrom Mar 24, 2014
Merged
[Console] Added standalone PSR-3 compliant logger#3696weaverryan merged 1 commit intosymfony:masterfrom
weaverryan merged 1 commit intosymfony:masterfrom
Conversation
Member
dunglas
commented
Mar 19, 2014
| Q | A |
|---|---|
| Doc fix? | no |
| New docs? | yes symfony/symfony#10194 |
| Applies to | 2.5 |
components/console/logger.rst
Outdated
Contributor
There was a problem hiding this comment.
maybe add a comma here since it does not hurt and they will copy paste so to reduce the diffs and for consistency too since you have used it above, i would also add them in the PR in symfony/symfony
Contributor
There was a problem hiding this comment.
same comment for LogLevel, the namespace requirement question
Member
Author
|
@cordoval thanks, fixed. |
components/console/logger.rst
Outdated
Contributor
There was a problem hiding this comment.
as a parameter in the constructor
Member
Author
|
@cordoval done. |
components/console/logger.rst
Outdated
Member
There was a problem hiding this comment.
Using the Logger (all words should be capitialized except from closed-class words)
Member
|
Thank you for creating this. I've decorated it a bit more, after you fixed those, I think it's fine! :) |
fabpot
added a commit
to symfony/symfony
that referenced
this pull request
Mar 19, 2014
…glas) This PR was merged into the 2.5-dev branch. Discussion ---------- [Console] Added standalone PSR-3 compliant logger This PR adds a standalone, PSR-3 compliant, logger to the Console component. It logs all messages on the console output. Messages of `DEBUG`, `INFO` and `NOTICE` levels are displayed using the `info` format (default to green). Higher levels are displayed using the `error` formatter (default to red). This logger is similar to the [Monolog's Console Handler](http://symfony.com/doc/current/cookbook/logging/monolog_console.html) but does not have any external dependency (except `php-fig/log`). This is useful for console applications and commands needing a lightweight PSR-3 compliant logger (e.g. required by a dependency or to display basic informations to the user). An usage example is available here: https://github.com/dunglas/php-schema.org-model/blob/master/src/SchemaOrgModel/Command/GenerateEntitiesCommand.php#L71 | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT | Doc PR | symfony/symfony-docs#3696 Commits ------- e40b34d [Console] Added standalone PSR-3 compliant logger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.