Add documentation for the new BinaryFileResponse class (#1866)#2416
Merged
weaverryan merged 3 commits intosymfony:2.2from Apr 4, 2013
Merged
Add documentation for the new BinaryFileResponse class (#1866)#2416weaverryan merged 3 commits intosymfony:2.2from
weaverryan merged 3 commits intosymfony:2.2from
Conversation
Contributor
jbafford
commented
Mar 30, 2013
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes (symfony/symfony#4546) |
| Applies to | 2.2 |
| Fixed tickets | #1866 |
book/controller.rst
Outdated
Member
There was a problem hiding this comment.
please add an empty line before this one
book/controller.rst
Outdated
Contributor
There was a problem hiding this comment.
A little typo here: I think you meant Symfony\\Component\\HttpFoundation\\BinaryFileResponse
Contributor
Author
There was a problem hiding this comment.
You're correct. I have that fixed now.
weaverryan
added a commit
that referenced
this pull request
Apr 4, 2013
Add documentation for the new BinaryFileResponse class (#1866)
weaverryan
added a commit
that referenced
this pull request
Apr 4, 2013
Contributor
|
Hey John! This is really great - and I get to learn about a new feature from your work ;). I've only made a few small changes and also mentioned Thanks! |
Contributor
Author
|
Glad to be of help! :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.