Skip to content

[Cache] Split PdoAdapter to DoctrineDbalAdapter#15903

Merged
javiereguiluz merged 1 commit intosymfony:5.4from
GromNaN:dbal/cache-pdo-5.4
Dec 27, 2021
Merged

[Cache] Split PdoAdapter to DoctrineDbalAdapter#15903
javiereguiluz merged 1 commit intosymfony:5.4from
GromNaN:dbal/cache-pdo-5.4

Conversation

@GromNaN
Copy link
Copy Markdown
Member

@GromNaN GromNaN commented Oct 7, 2021

In Symfony 5.4, the PdoAdapter is split and DoctrineDbalAdapter is created.

Q A
Branch? 5.4
Tickets Fix symfony/symfony#42962
Code PR symfony/symfony#43362

@carsonbot carsonbot added this to the 5.4 milestone Oct 7, 2021
@GromNaN GromNaN mentioned this pull request Oct 7, 2021
Merged
@javiereguiluz javiereguiluz added the Waiting Code Merge Docs for features pending to be merged label Oct 8, 2021
@carsonbot carsonbot modified the milestones: 5.4, next Oct 8, 2021
fabpot added a commit to symfony/symfony that referenced this pull request Oct 19, 2021
@fabpot
feature #43362 [Cache] Split PdoAdapter into DoctrineDbalAdapter (Gro…
4418be1 
…mNaN)

This PR was squashed before being merged into the 5.4 branch.

Discussion
----------

[Cache] Split PdoAdapter into DoctrineDbalAdapter

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | yes
| Tickets       | Fix #42962
| License       | MIT
| Doc PR        | symfony/symfony-docs#15903

Commits
-------

db665be [Cache] Split PdoAdapter into DoctrineDbalAdapter
@GromNaN GromNaN mentioned this pull request Oct 20, 2021
Merged
@GromNaN GromNaN force-pushed the dbal/cache-pdo-5.4 branch 2 times, most recently from cb094c5 to 00e704b Compare October 20, 2021 17:23
@GromNaN
Copy link
Copy Markdown
Member Author

GromNaN commented Dec 13, 2021 •
edited
Loading

Code was merged in 5.4. I just rebased this PR.

@javiereguiluz javiereguiluz added Status: Reviewed and removed Status: Needs Review Waiting Code Merge Docs for features pending to be merged labels Dec 27, 2021
@javiereguiluz javiereguiluz merged commit 039a4a6 into symfony:5.4 Dec 27, 2021
@javiereguiluz
Copy link
Copy Markdown
Member

javiereguiluz commented Dec 27, 2021

Thanks Jérôme! While upmerging into 6.0 I removed the .. deprecated:: 5.4 comment but made no other changes. Is this enough? Thanks!

@nicolas-grekas nicolas-grekas mentioned this pull request Aug 4, 2023
Merged
javiereguiluz added a commit that referenced this pull request Aug 7, 2023
@javiereguiluz
minor #18698 [Cache] Fix doc for Doctrine DBAL adapter (nicolas-grekas)
e5376be 
This PR was merged into the 5.4 branch.

Discussion
----------

[Cache] Fix doc for Doctrine DBAL adapter

Fix #15903

Commits
-------

1e41505 [Cache] Fix doc for Doctrine DBAL adapter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

Cache Status: Reviewed

Projects

None yet

Milestone

next

Development

Successfully merging this pull request may close these issues.

Split PDO and DBAL adapters

3 participants

@GromNaN @javiereguiluz @carsonbot