[Debug] Added option to specify the event dispatcher in debug:event-dispatcher#14650
Merged
javiereguiluz merged 1 commit intosymfony:5.xfrom Dec 7, 2020
TimoBakx:debug-eventdispatcher-firewall
Merged
[Debug] Added option to specify the event dispatcher in debug:event-dispatcher#14650javiereguiluz merged 1 commit intosymfony:5.xfrom TimoBakx:debug-eventdispatcher-firewall
javiereguiluz merged 1 commit intosymfony:5.xfrom
TimoBakx:debug-eventdispatcher-firewall
Conversation
6 tasks
OskarStark
reviewed
Dec 4, 2020
derrabus
added a commit
to symfony/symfony
that referenced
this pull request
Dec 5, 2020
…spatcher in debug:event-dispatcher (TimoBakx) This PR was squashed before being merged into the 5.3-dev branch. Discussion ---------- [FrameworkBundle] Added option to specify the event dispatcher in debug:event-dispatcher | Q | A | ------------- | --- | Branch? | 5.x | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | N/A | License | MIT | Doc PR | symfony/symfony-docs#14650 | Tags | #SymfonyHackday ### Description: In the recent security improvements, new event dispatchers were added (one for each firewall). These were not visible in the `debug:event-dispatcher` command. This PR adds an option to define a event dispatcher to show the events (and listeners) for that specific event dispatcher. Without any options, the default dispatcher is shown (identical to previous working) In order to be able to fetch specific event dispatchers, I tagged all event dispatchers with a new `kernel.event-dispatcher` tag. ### Usage: `bin/console debug:event-dispatcher --dispatcher=[servicename] [other options] [event]` ### Subtasks: - [x] Add `dispatcher` option - [x] Add `kernel.event_dispatcher` tag to all event dispatchers - [x] Add autoconfigure tag for services implementing `EventDispatcherInterface` - [x] Update Descriptor classes to specify the chosen dispatcher - [x] Update changelog - [x] Add documentation Commits ------- 62398b5 [FrameworkBundle] Added option to specify the event dispatcher in debug:event-dispatcher
OskarStark
approved these changes
Dec 6, 2020
maxhelias
approved these changes
Dec 6, 2020
Member
|
Hi Timo! Thanks for contributing this feature and its docs! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documentation for symfony/symfony#39276
Part of #SymfonyHackday