Removed useless parentheses in Assert annotations#10676
Merged
javiereguiluz merged 1 commit intosymfony:2.8from Nov 16, 2018
Merged
Removed useless parentheses in Assert annotations#10676javiereguiluz merged 1 commit intosymfony:2.8from
javiereguiluz merged 1 commit intosymfony:2.8from
Conversation
javiereguiluz
approved these changes
Nov 15, 2018
Member
|
Thanks Thomas! Personally I like this change a lot. Cheers! |
javiereguiluz
added a commit
that referenced
this pull request
Nov 16, 2018
…sbisignani) This PR was merged into the 2.8 branch. Discussion ---------- Removed useless parentheses in Assert annotations To be consistent, this PR removes the useless empty parentheses in the `@Assert` annotations for constraints. Sometimes `@Assert` annotations for constraints without options were used with empty parentheses, sometimes without parentheses. Commits ------- f5980f0 Removed useless parentheses in Assert annotations
Member
|
I've only found (and fixed) one occurrence of empty parenthesis while merging thi in the upper branches, so I think we're good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be consistent, this PR removes the useless empty parentheses in the
@Assertannotations for constraints.Sometimes
@Assertannotations for constraints without options were used with empty parentheses, sometimes without parentheses.