[Profiler] Re-added context information to log list#7806
[Profiler] Re-added context information to log list#7806mweimerskirch wants to merge 1 commit intosymfony:masterfrom mweimerskirch:patch-16
Conversation
mweimerskirch
commented
Apr 22, 2013
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #7679 |
| License | MIT |
There was a problem hiding this comment.
we are not using yaml_encode anymore in the profiler but json_encode instead. And to avoid blackslashes, you must use |json_encode(64 b-or 256)
There was a problem hiding this comment.
No problem, I'll change that.
Would (|json_encode(constant("JSON_UNESCAPED_SLASHES") b-or constant("JSON_UNESCAPED_UNICODE"))) be acceptable as well? IMHO constants are more readable than numeric values.
There was a problem hiding this comment.
It's done this way for a reason: because those constant do not exist on all Symfony PHP supported versions. So, using constants would break on those versions of PHP.
There was a problem hiding this comment.
Alright, I see. Thanks for the explanation. I modified the pull request accordingly.
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes #7806). Discussion ---------- [Profiler] Re-added context information to log list | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #7679 | License | MIT Commits ------- 55c2044 [Profiler] Re-added context information to log list