Skip to content

[FrameworkBundle] disable the Lock integration to not register the deduplicate middleware#60559

Merged
nicolas-grekas merged 1 commit intosymfony:7.3from
xabbuh:deduplicate-middleware
May 28, 2025
Merged

[FrameworkBundle] disable the Lock integration to not register the deduplicate middleware#60559
nicolas-grekas merged 1 commit intosymfony:7.3from
xabbuh:deduplicate-middleware

Conversation

@xabbuh
Copy link
Copy Markdown
Member

@xabbuh xabbuh commented May 27, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? no
Issues
License MIT

Before the creation of the 7.4 branch the tests did not fail because on our high deps job we checked out the 7.2 branch and ran that with locally patched components (i.e. components that were changed by the commit being tested). On all other jobs the lock integration is disabled implicitly.

@xabbuh
Copy link
Copy Markdown
Member Author

xabbuh commented May 27, 2025

@stof
Copy link
Copy Markdown
Member

stof commented May 27, 2025

shouldn't default_middleware => false disable the deduplicate middleware even when the lock component is enabled ?

I would say this caught an actual bug.

@xabbuh
Copy link
Copy Markdown
Member Author

xabbuh commented May 27, 2025

@stof Yes, and that part works as expected. But we have three buses here and for the messenger.bus.commands and messenger.bus.events buses default_middleware is not set to false.

@xabbuh xabbuh force-pushed the deduplicate-middleware branch from 55e8879 to 3cf847f Compare May 28, 2025 06:56
@xabbuh xabbuh requested a review from stof May 28, 2025 07:02
@nicolas-grekas
Copy link
Copy Markdown
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 8943c41 into symfony:7.3 May 28, 2025
10 of 11 checks passed
@xabbuh xabbuh deleted the deduplicate-middleware branch May 28, 2025 16:37
nicolas-grekas added a commit that referenced this pull request Jun 20, 2025
…gister the deduplicate middleware (xabbuh)

This PR was merged into the 7.3 branch.

Discussion
----------

[FrameworkBundle] disable the Lock integration to not register the deduplicate middleware

| Q             | A
| ------------- | ---
| Branch?       | 7.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        |
| License       | MIT

similar to #60559 to fix the high deps failures

Commits
-------

9f65dd0 disable the Lock integration to not register the deduplicate middleware
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants