Work around parse_url() bug#58218
Merged
nicolas-grekas merged 1 commit intosymfony:5.4from Sep 11, 2024
Merged
Conversation
This was referenced Sep 10, 2024
OskarStark
reviewed
Sep 11, 2024
src/Symfony/Bundle/FrameworkBundle/Tests/Controller/RedirectControllerTest.php
Outdated
Show resolved
Hide resolved
5db1928 to
fb76e53
Compare
derrabus
approved these changes
Sep 11, 2024
This was referenced Sep 21, 2024
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Nov 13, 2024
This PR was merged into the 5.4 branch. Discussion ---------- Work around `parse_url()` bug (bis) | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Issues | #58313 | License | MIT This PR is a follow up of #58218 parse_url behaves incorrectly when parsing some URLs that don't contain `?` or `#`. This PR ensures that one of those chars is always found when calling the function. Commits ------- 80257ea Work around parse_url() bug (bis)
1 task
4 tasks
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works around
parse_urlphp/php-src#12703