[DoctrineBridge] try to fix deprecations from doctrine/persistence#34949
Merged
nicolas-grekas merged 1 commit intosymfony:3.4from Dec 12, 2019
Merged
[DoctrineBridge] try to fix deprecations from doctrine/persistence#34949nicolas-grekas merged 1 commit intosymfony:3.4from
nicolas-grekas merged 1 commit intosymfony:3.4from
Conversation
0221a63 to
ef83802
Compare
ef83802 to
8070aa7
Compare
8070aa7 to
53a4711
Compare
nicolas-grekas
commented
Dec 12, 2019
| * @return ORMQueryBuilderLoader | ||
| */ | ||
| public function getLoader(ObjectManager $manager, $queryBuilder, $class) | ||
| public function getLoader(LegacyObjectManager $manager, $queryBuilder, $class) |
Member
Author
There was a problem hiding this comment.
changing the type would be a BC break
| * @author Lukas Kahwe Smith <smith@pooteeweet.org> | ||
| */ | ||
| abstract class ManagerRegistry extends AbstractManagerRegistry implements ContainerAwareInterface | ||
| abstract class ManagerRegistry extends LegacyAbstractManagerRegistry implements ContainerAwareInterface |
Member
Author
There was a problem hiding this comment.
changing the type would be a BC break
| * @author Fabien Potencier <fabien@symfony.com> | ||
| */ | ||
| interface RegistryInterface extends ManagerRegistryInterface | ||
| interface RegistryInterface extends LegacyManagerRegistry |
Member
Author
There was a problem hiding this comment.
changing the type would be a BC break
| } | ||
|
|
||
| public function setRepository(EntityManagerInterface $entityManager, $entityName, ObjectRepository $repository) | ||
| public function setRepository(EntityManagerInterface $entityManager, $entityName, LegacyObjectRepository $repository) |
Member
Author
There was a problem hiding this comment.
changing the type would be a BC break
| } | ||
|
|
||
| public function load(ObjectManager $manager) | ||
| public function load(LegacyObjectManager $manager) |
Member
Author
There was a problem hiding this comment.
changing the type would be a BC break
| * @return EntityLoaderInterface | ||
| */ | ||
| abstract public function getLoader(ObjectManager $manager, $queryBuilder, $class); | ||
| abstract public function getLoader(LegacyObjectManager $manager, $queryBuilder, $class); |
Member
Author
There was a problem hiding this comment.
changing the type would be a BC break
Contributor
There was a problem hiding this comment.
Would it really? It's a class alias, so they are the same thing, right?
Member
Author
There was a problem hiding this comment.
Not when v1.2 is checked out
nicolas-grekas
added a commit
that referenced
this pull request
Dec 12, 2019
…ersistence (nicolas-grekas) This PR was merged into the 3.4 branch. Discussion ---------- [DoctrineBridge] try to fix deprecations from doctrine/persistence | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Follows doctrine/persistence#71 But the BC layer is not working yet, as highlighted by the `XXX` in the attached patch. At least for the corresponding interfaces, doctrine/persistence should always alias the legacy name to the new one. /cc @greg0ire @alcaeus FYI Commits ------- 53a4711 [DoctrineBridge] try to fix deprecations from doctrine/persistence
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows doctrine/persistence#71
But the BC layer is not working yet, as highlighted by the
XXXin the attached patch.At least for the corresponding interfaces, doctrine/persistence should always alias the legacy name to the new one.already the case./cc @greg0ire @alcaeus FYI