Skip to content

[ErrorHandler] Remove Symfony ClassLoader support in an error enhancer#34284

Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom
fancyweb:error-handler-remove-sf-class-loader
Nov 8, 2019
Merged

[ErrorHandler] Remove Symfony ClassLoader support in an error enhancer#34284
nicolas-grekas merged 1 commit intosymfony:masterfrom
fancyweb:error-handler-remove-sf-class-loader

Conversation

@fancyweb
Copy link
Copy Markdown
Contributor

@fancyweb fancyweb commented Nov 7, 2019

Q A
Branch? master
Bug fix? no
New feature? no
Deprecations? no
Tickets #33053 (comment)
License MIT
Doc PR -

Throwing a deprecation for this on 4.4 looks useless to me as the component was deprecated 2 years ago and stopping its support will not break anything.

@nicolas-grekas nicolas-grekas added this to the 5.0 milestone Nov 8, 2019
Comment thread src/Symfony/Component/ErrorHandler/ErrorEnhancer/ClassNotFoundErrorEnhancer.php Outdated
@fancyweb fancyweb force-pushed the error-handler-remove-sf-class-loader branch from dfc5cbb to e745654 Compare November 8, 2019 08:41
@nicolas-grekas
Copy link
Copy Markdown
Member

Thank you @fancyweb.

nicolas-grekas added a commit that referenced this pull request Nov 8, 2019
…error enhancer (fancyweb)

This PR was merged into the 5.0-dev branch.

Discussion
----------

[ErrorHandler] Remove Symfony ClassLoader support in an error enhancer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | #33053 (comment)
| License       | MIT
| Doc PR        | -

Throwing a deprecation for this on 4.4 looks useless to me as the component was deprecated 2 years ago and stopping its support will not break anything.

Commits
-------

e745654 [ErrorHandler] Remove Symfony ClassLoader support in an error enhancer
@nicolas-grekas nicolas-grekas merged commit e745654 into symfony:master Nov 8, 2019
@fancyweb fancyweb deleted the error-handler-remove-sf-class-loader branch November 8, 2019 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants