Remove \Throwable bubbling down support deprecation layer#34265
Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom Nov 8, 2019
Merged
Conversation
Member
|
Can you please rebase to trigger the CI again? |
db14f3a to
1b402f1
Compare
src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php
Outdated
Show resolved
Hide resolved
1808c0a to
8eae4cd
Compare
nicolas-grekas
approved these changes
Nov 7, 2019
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
(once comments are addressed)
8eae4cd to
b0ac75e
Compare
derrabus
approved these changes
Nov 7, 2019
nicolas-grekas
added a commit
that referenced
this pull request
Nov 8, 2019
This PR was merged into the 4.4 branch. Discussion ---------- Unallow symfony/http-kernel ^5.0 | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | #34265 (comment) | License | MIT | Doc PR | - The components that have a data collector cannot be compatible with HttpKernel `DataCollectorInterface` 5.0. Commits ------- da454db Unallow symfony/http-kernel ^5.0
b0ac75e to
41d6706
Compare
41d6706 to
ffcfdb4
Compare
Member
|
Thank you @fancyweb. |
nicolas-grekas
added a commit
that referenced
this pull request
Nov 8, 2019
…r (fancyweb) This PR was merged into the 5.0-dev branch. Discussion ---------- Remove \Throwable bubbling down support deprecation layer | Q | A | ------------- | --- | Branch? | master | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Remove deprecation layer of #33065 Commits ------- ffcfdb4 Remove \Throwable support deprecation layer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove deprecation layer of #33065