[PhpUnitBridge] Remove use of ForwardCompatTrait#32889
Merged
nicolas-grekas merged 1 commit intosymfony:3.4from Aug 3, 2019
Merged
[PhpUnitBridge] Remove use of ForwardCompatTrait#32889nicolas-grekas merged 1 commit intosymfony:3.4from
nicolas-grekas merged 1 commit intosymfony:3.4from
Conversation
f97abb5 to
2d87331
Compare
17680e7 to
5154708
Compare
f5d60c0 to
feda555
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2019
…jderusse) This PR was merged into the 4.4 branch. Discussion ---------- [PhpUnitBridge] Inject ForwardCompatibiliy in TestCase | Q | A | ------------- | --- | Branch? | 4.4 | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | not yet | Fixed tickets | #32844 | License | MIT | Doc PR | NA This PR replace the previous trait `ForwardCompatTestTrait` by injecting forward compatibility code in phpunit itself which allow to use the polyfill methods in tests without changing the code. when using `simple_phpunit` the env variable `$PHPUNIT_REMOVE_RETURN_TYPEHINT=1` (default 0) removes the `: void` typehint in public and protected methods (allow to use 7.4 8 in 3.4 branch) note: once merged, all tests have to be fixed. see #32889 Commits ------- 016bd8d Inject ForwardCompatibiliy in TestCase
432c4de to
ad2225f
Compare
ad2225f to
ac6242f
Compare
Member
|
Thank you @jderusse. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 3, 2019
This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Remove use of ForwardCompatTrait | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #32844 | License | MIT | Doc PR | NA With #32882 the ForwardCompatibilityTrait is injected in TestCase which now act as a true polyfill Commits ------- ac6242f Remove use of ForwardCompatTrait
hultberg
pushed a commit
to hultberg/symfony
that referenced
this pull request
Sep 17, 2021
…(jderusse) This PR was merged into the 3.4 branch. Discussion ---------- [PhpUnitBridge] Remove use of ForwardCompatTrait | Q | A | ------------- | --- | Branch? | 3.4 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#32844 | License | MIT | Doc PR | NA With symfony#32882 the ForwardCompatibilityTrait is injected in TestCase which now act as a true polyfill Commits ------- ac6242f Remove use of ForwardCompatTrait
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With #32882 the ForwardCompatibilityTrait is injected in TestCase which now act as a true polyfill