[VarDumper] Skip some tests on custom xdebug.file_link_format#26776
Merged
nicolas-grekas merged 1 commit intosymfony:3.4from Apr 3, 2018
ogizanagi:var_dumper/tests/skip_on_custom_xdebug_file_link_format
Merged
[VarDumper] Skip some tests on custom xdebug.file_link_format#26776nicolas-grekas merged 1 commit intosymfony:3.4from ogizanagi:var_dumper/tests/skip_on_custom_xdebug_file_link_format
nicolas-grekas merged 1 commit intosymfony:3.4from
ogizanagi:var_dumper/tests/skip_on_custom_xdebug_file_link_format
Conversation
Member
|
3.3 is EOLed |
Contributor
Author
|
Of course... 😅 Target changed. |
nicolas-grekas
approved these changes
Apr 3, 2018
lyrixx
approved these changes
Apr 3, 2018
Member
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 3, 2018
…ormat (ogizanagi) This PR was merged into the 3.4 branch. Discussion ---------- [VarDumper] Skip some tests on custom xdebug.file_link_format | Q | A | ------------- | --- | Branch? | 3.4 <!-- see below --> | Bug fix? | no | New feature? | no <!-- don't forget to update src/**/CHANGELOG.md files --> | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A <!-- required for new features --> Those tests are failing locally if a custom `xdebug.file_link_format` value is set. Let's skip them as for `FrameworkExtensionTest::testFileLinkFormat`. This will prevent some WTF moments and any actual error on these tests will be reported by the CI (IMHO isn't worth the hassle of updating the tests to handle both cases). Commits ------- f9216ed [VarDumper] Skip some tests on custom xdebug.file_link_format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Those tests are failing locally if a custom
xdebug.file_link_formatvalue is set.Let's skip them as for
FrameworkExtensionTest::testFileLinkFormat.This will prevent some WTF moments and any actual error on these tests will be reported by the CI (IMHO isn't worth the hassle of updating the tests to handle both cases).