Skip to content

[Translation] add gettext PO and MO Dumper#2590

Merged
fabpot merged 1 commit intosymfony:masterfrom
stealth35:gettext_dumper
Nov 10, 2011
Merged

[Translation] add gettext PO and MO Dumper#2590
fabpot merged 1 commit intosymfony:masterfrom
stealth35:gettext_dumper

Conversation

@stealth35
Copy link
Copy Markdown
Contributor

@stealth35 stealth35 commented Nov 9, 2011

See #2412

Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -

stof
stof reviewed Nov 9, 2011
View reviewed changes
src/Symfony/Component/Translation/Dumper/PoFileDumper.php Outdated
Copy link
Copy Markdown
Member

@stof stof Nov 9, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

private methods should be placed after protected ones according to the CS.

Copy link
Copy Markdown
Contributor Author

@stealth35 stealth35 Nov 9, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank done

fabpot added a commit that referenced this pull request Nov 10, 2011
@fabpot
merged branch stealth35/gettext_dumper (PR #2590)
5882a98 
Commits
-------

56cb7a5 [Translation] add gettext PO and MO Dumper

Discussion
----------

[Translation] add gettext PO and MO Dumper

See #2412

    Bug fix: no
    Feature addition: yes
    Backwards compatibility break: no
    Symfony2 tests pass: yes
    Fixes the following tickets: -
@fabpot fabpot merged commit 56cb7a5 into symfony:master Nov 10, 2011
@jakzal jakzal mentioned this pull request Dec 23, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stealth35 @stof @fabpot