Moved $this->setDate() before the deprecation handling.#22304
Closed
mpdonadio wants to merge 2 commits intosymfony:3.2from
Closed
Moved $this->setDate() before the deprecation handling.#22304mpdonadio wants to merge 2 commits intosymfony:3.2from
mpdonadio wants to merge 2 commits intosymfony:3.2from
Conversation
Member
|
Thank you @mpdonadio. |
nicolas-grekas
added a commit
that referenced
this pull request
Apr 7, 2017
…pdonadio) This PR was squashed before being merged into the 3.2 branch (closes #22304). Discussion ---------- Moved $this->setDate() before the deprecation handling. | Q | A | ------------- | --- | Branch? | 3.2 <!-- see comment below --> | Bug fix? | yes | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no? | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | #... <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | symfony/symfony-docs#... <!--highly recommended for new features--> <!-- - Bug fixes must be submitted against the lowest branch where they apply (lowest branches are regularly merged to upper ones so they get the fixes too). - Features and deprecations must be submitted against the master branch. - Please fill in this template according to the PR you're about to submit. - Replace this comment by a description of what your PR is solving. --> #22036 merged the patch into the wrong place; the `$this->setDate()` happens after the deprecation handling, so it does not always get called. See also https://www.drupal.org/node/2712647?page=1#comment-12025349 Commits ------- b6df4e7 Moved ->setDate() before the deprecation handling.
3 tasks
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#22036 merged the patch into the wrong place; the
$this->setDate()happens after the deprecation handling, so it does not always get called.See also https://www.drupal.org/node/2712647?page=1#comment-12025349