[Console] SfStyleTest: Remove COLUMNS env on tearDown#21456
Merged
nicolas-grekas merged 1 commit intosymfony:3.2from Jan 30, 2017
ogizanagi:fix/console/test/sf_style/col_reset
Merged
[Console] SfStyleTest: Remove COLUMNS env on tearDown#21456nicolas-grekas merged 1 commit intosymfony:3.2from ogizanagi:fix/console/test/sf_style/col_reset
nicolas-grekas merged 1 commit intosymfony:3.2from
ogizanagi:fix/console/test/sf_style/col_reset
Conversation
Contributor
ogizanagi
commented
Jan 29, 2017
| Q | A |
|---|---|
| Branch? | 3.2 |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #21424 (comment) |
| License | MIT |
| Doc PR | N/A |
Member
|
Thank you @ogizanagi. |
nicolas-grekas
added a commit
that referenced
this pull request
Jan 30, 2017
…gizanagi) This PR was merged into the 3.2 branch. Discussion ---------- [Console] SfStyleTest: Remove COLUMNS env on tearDown | Q | A | ------------- | --- | Branch? | 3.2 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #21424 (comment) | License | MIT | Doc PR | N/A Commits ------- b715a36 [Console] SfStyleTest: Remove COLUMN env on tearDown
Member
|
would be even better to reset it to the previous value if there was one |
Member
|
COLUMN is a special env var you cannot really set in fact (try in bash), so removing is fine to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.