Skip to content

[FrameworkBundle] Configurable Serializer name converter#14987

Merged
fabpot merged 1 commit intosymfony:2.8from
dunglas:framework_name_converter
Aug 1, 2015
Merged

[FrameworkBundle] Configurable Serializer name converter#14987
fabpot merged 1 commit intosymfony:2.8from
dunglas:framework_name_converter

Conversation

@dunglas
Copy link
Copy Markdown
Member

@dunglas dunglas commented Jun 15, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets n/a
License MIT
Doc PR symfony/symfony-docs#5483
  • Add tests

@dunglas
Copy link
Copy Markdown
Member Author

dunglas commented Jun 18, 2015

ping @symfony/deciders

fabpot
fabpot reviewed Jun 19, 2015
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php Outdated
Copy link
Copy Markdown
Member

@fabpot fabpot Jun 19, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC, the isset part is not needed.

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Jun 19, 2015

Can you also create the PR for the docs?

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Jun 20, 2015

Don't you have to set the default value of the name_converter option to serializer.name_converter.camel_case_to_snake_case so that it is taken by default? Otherwise, the service were only used in the tests.

@dunglas
Copy link
Copy Markdown
Member Author

dunglas commented Jun 20, 2015

No. If you do that everything will be converted by default and this is not intended nor a best practice.

The name converter definition is here just for convenience and will be removed during the container compilation when not used.

@dunglas dunglas force-pushed the framework_name_converter branch from 0c52409 to e500a71 Compare July 4, 2015 10:10
@dunglas dunglas mentioned this pull request Jul 4, 2015
Closed
@dunglas
Copy link
Copy Markdown
Member Author

dunglas commented Jul 4, 2015

Code updated and doc added (symfony/symfony-docs#5483)

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Jul 7, 2015

No. If you do that everything will be converted by default and this is not intended nor a best practice.

The name converter definition is here just for convenience and will be removed during the container compilation when not used.

Thanks for explaining your intentions.

@xabbuh
Copy link
Copy Markdown
Member

xabbuh commented Jul 7, 2015

👍

1 similar comment
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Jul 7, 2015

👍

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Aug 1, 2015

Thank you @dunglas.

@fabpot fabpot merged commit e500a71 into symfony:2.8 Aug 1, 2015
fabpot added a commit that referenced this pull request Aug 1, 2015
@fabpot
feature #14987 [FrameworkBundle] Configurable Serializer name convert…
f02a5dc 
…er (dunglas)

This PR was merged into the 2.8 branch.

Discussion
----------

[FrameworkBundle] Configurable Serializer name converter

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | symfony/symfony-docs#5483

- [x] Add tests

Commits
-------

e500a71 [FrameworkBundle] Configurable Serializer name converter
@fabpot fabpot mentioned this pull request Nov 16, 2015
Merged
@dunglas dunglas deleted the framework_name_converter branch December 5, 2015 09:03
wouterj added a commit to symfony/symfony-docs that referenced this pull request Feb 6, 2016
@wouterj
feature #5483 [FrameworkBundle] Name converter of Serializer (dunglas)
41d43dd 
This PR was squashed before being merged into the 2.8 branch (closes #5483).

Discussion
----------

[FrameworkBundle] Name converter of Serializer

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes symfony/symfony#14987
| Applies to    | 2.8
| Fixed tickets | n/a

Commits
-------

7a4d9fc [FrameworkBundle] Name converter of Serializer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

FrameworkBundle Serializer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dunglas @fabpot @xabbuh