Skip to content

[Form] Remove deprecated setDefaultOptions and OptionsResolverInterface#13407

Merged
fabpot merged 2 commits intosymfony:masterfrom
peterrehm:abstract-type-3.0
Feb 5, 2015
Merged

[Form] Remove deprecated setDefaultOptions and OptionsResolverInterface#13407
fabpot merged 2 commits intosymfony:masterfrom
peterrehm:abstract-type-3.0

Conversation

@peterrehm
Copy link
Copy Markdown
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Tests pass? yes
Fixed tickets -
License MIT
Doc PR symfony/symfony-docs#4786
Related #12891

@peterrehm
Copy link
Copy Markdown
Contributor Author

Rebased, good for review.

@peterrehm peterrehm changed the title [Form] Remove deprecated setDefaultOptions methods [Form] Remove deprecated setDefaultOptions and OptionsResolverInterface Jan 20, 2015
@peterrehm
Copy link
Copy Markdown
Contributor Author

Also removed the OptionsResolverInterface and it's usages.

@peterrehm
Copy link
Copy Markdown
Contributor Author

@stof Can you have a look at those changes? Tests are failing, but looks unrelated...

@peterrehm
Copy link
Copy Markdown
Contributor Author

Anyone up for a review?

@Tobion
Copy link
Copy Markdown
Contributor

Tobion commented Jan 29, 2015

Looks ok 👍

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Feb 5, 2015

Thank you @peterrehm.

@fabpot fabpot merged commit 9b9158b into symfony:master Feb 5, 2015
fabpot added a commit that referenced this pull request Feb 5, 2015
…ResolverInterface (peterrehm)

This PR was merged into the 3.0-dev branch.

Discussion
----------

[Form] Remove deprecated setDefaultOptions and OptionsResolverInterface

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | symfony/symfony-docs#4786
| Related        | #12891

Commits
-------

9b9158b Remove the deprecated OptionsResolverInterface
6026781 Removed deprecated setDefaultOptions methods
@peterrehm peterrehm deleted the abstract-type-3.0 branch June 7, 2015 15:50
@fabpot fabpot mentioned this pull request Nov 16, 2015
stof added a commit that referenced this pull request Dec 5, 2015
This PR was submitted for the master branch but it was merged into the 3.0 branch instead (closes #16752).

Discussion
----------

[Form] document changes to form type interfaces

| Q             | A
| ------------- | ---
| Fixed tickets | #13407, #16024, #16724, #16749
| License       | MIT

Commits
-------

b297a0c [Form] document changes to form type interfaces
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants