Skip to content

Unify the way to provide expression functions for the DI container#13013

Merged
fabpot merged 1 commit intosymfony:2.6from
stof:expression_language_di
Dec 17, 2014
Merged

Unify the way to provide expression functions for the DI container#13013
fabpot merged 1 commit intosymfony:2.6from
stof:expression_language_di

Conversation

@stof
Copy link
Copy Markdown
Member

@stof stof commented Dec 17, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #13012
License MIT
Doc PR n/a

Function providers registered on the ContainerBuilder are now reused by the PhpDumper when dumping the container instead of forcing to register them again.
I consider it as a bugfix, because the hook introduced in 2.6 is currently unusable.

Function providers registered on the ContainerBuilder are now reused by
the PhpDumper when dumping the container instead of forcing to register
them again.
Closes symfony#13012
@fabpot
Copy link
Copy Markdown
Member

fabpot commented Dec 17, 2014

Thank you @stof.

@fabpot fabpot merged commit 8425e4d into symfony:2.6 Dec 17, 2014
fabpot added a commit that referenced this pull request Dec 17, 2014
…ontainer (stof)

This PR was merged into the 2.6 branch.

Discussion
----------

Unify the way to provide expression functions for the DI container

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #13012
| License       | MIT
| Doc PR        | n/a

Function providers registered on the ContainerBuilder are now reused by the PhpDumper when dumping the container instead of forcing to register them again.
I consider it as a bugfix, because the hook introduced in 2.6 is currently unusable.

Commits
-------

8425e4d Unify the way to provide expression functions for the DI container
@stof stof deleted the expression_language_di branch December 18, 2014 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants