[Serializer] Add deserializing to an array of objects#12066
Closed
acleon wants to merge 1 commit intosymfony:masterfrom
acleon:deserialize_collection
Closed
[Serializer] Add deserializing to an array of objects#12066acleon wants to merge 1 commit intosymfony:masterfrom acleon:deserialize_collection
acleon wants to merge 1 commit intosymfony:masterfrom
acleon:deserialize_collection
Conversation
Added a deserializeCollection method to the Serializer that,after the decoding stage, denormalizes each element of the resulting array, rather than the array itself.
|
👍 Would love to see this feature implemented soon! :) |
Member
|
Maybe I've missed something but isn't this feature already present in Maybe this logic should be moved in |
Member
|
@acleon is this PR still useful (see my previous comment)? |
Member
|
Closing as there is no feedback. |
dunglas
added a commit
that referenced
this pull request
May 27, 2015
This PR was merged into the 2.8 branch. Discussion ---------- [Serializer] Support for array denormalization | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | none | License | MIT | Doc PR | none (yet) This is a rebase of #14343 against the 2.8 branch. I had to implement a couple of API endpoints that receive data as JSON-serialized arrays of objects. The current implementation of the Serializer component is capable of serializing such arrays, but so far this operation is a one-way-road. This PR is an attempt to change this. ## Demo ```php class Dummy { public $foo; public $bar; public function __construct($foo = null, $bar = null) { $this->foo = $foo; $this->bar = $bar; } } $serializer = new \Symfony\Component\Serializer\Serializer( array( new \Symfony\Component\Serializer\Normalizer\PropertyNormalizer(), new \Symfony\Component\Serializer\Normalizer\ArrayDenormalizer() ), array( new \Symfony\Component\Serializer\Encoder\JsonEncoder() ) ); $json = $serializer->serialize( array( new Dummy('one', 'two'), new Dummy('three', 'four') ), 'json' ); echo $json . "\n\n"; // Deserialize the JSON string, so we get back to where we started from. $data = $serializer->deserialize($json, 'Dummy[]', 'json'); var_dump($data); ``` By appending `[]` to the type parameter, you indicate that you expect to deserialize an array of objects of the given type. This is the same notation that phpDocumentor uses to indicate collections. The denormalization of the array is implemented recursively: The denormalizer simply calls `Serializer::denormalize()` on each element of the array. This way, the ArrayDenormalizer can be combined with any other denormalizer. ## Side effects For this implementation, I had to touch `GetSetMethodNormalizer`, `PropertyNormalizer` and `CustomNormalizer`. Those classes expected `supportsDenormalization` to be called with a valid class in the `$type` parameter. Instead of throwing a reflection exception, they now simply return false. I'm not exactly sure, if this is should be considered to be a BC break. This implementation violates the `SerializerInterface` which declared `deserialize()` to always return an object. But imho, the assumption that serialized data always represents an object is too restrictive anyway. Also, this declaration is not consistent with the `serialize()` method which accepts `mixed` as input type for the data to serialize. ## Other PRs I've found an older PR adressing this issue, #12066. That PR was closed because the contributor did not reply to feedback. Commits ------- 0573f28 Support for array denormalization.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
deserializeCollectionmethod to the Serializer so that collections of models can be deserialized without having to split out the decoding and denormalization stages yourself, or having to create a custom denormalizer for the collection.