[FrameworkBundle] Added a translation:debug command#10076
Closed
florianv wants to merge 1 commit intosymfony:masterfrom
Closed
[FrameworkBundle] Added a translation:debug command#10076florianv wants to merge 1 commit intosymfony:masterfrom
florianv wants to merge 1 commit intosymfony:masterfrom
Conversation
Contributor
|
👍 very nice idea |
Member
|
I see several issues with this command:
May I point you to https://github.com/Incenteev/IncenteevTranslationCheckerBundle which implement a few commands to check translations (only 2 at the moment, but more are planned) ? |
Contributor
Author
|
@stof you can pass |
Contributor
Author
|
As per @stof comment I sanitized and truncated (limited to 40 chars) the messages so they can be previewed without breaking the output (the most important informations being the state and id) |
Contributor
|
I see no added tests or docu PR |
Member
|
I've fixed a bunch of small edge cases on top of this PR. See #10368 |
fabpot
added a commit
that referenced
this pull request
Mar 3, 2014
…abpot) This PR was merged into the 2.5-dev branch. Discussion ---------- [FrameworkBundle] Added a translation:debug command | Q | A | ------------- | --- | Bug fix? | no | New feature? | yes | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This PR is based on #10076 but fixes a bunch of issues for edge cases. It also uses the new Table helper. Original description: This pull request adds a `translation:debug` command that can be used to inspect unused / missing messages and compare them with the fallback ones (for example to detect copy pasted strings). This is inspired by this ruby project https://github.com/glebm/i18n-tasks Example of output:  Commits ------- f039bde [FrameworkBundle] fixed edge cases for translation:debug and tweaked the output 597a310 Added a translation:debug command
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a
translation:debugcommand that can be used to inspect unused / missing messages and compare them with the fallback ones (for example to detect copy pasted strings). This is inspired by this ruby project https://github.com/glebm/i18n-tasksExample of output: