add new PHP 7.4 functions#181
Merged
nicolas-grekas merged 1 commit intosymfony:masterfrom Aug 6, 2019
Merged
Conversation
95d7473 to
02a54ab
Compare
stof
reviewed
Jul 22, 2019
Member
|
Oh, please list the polyfill in the root composer.json and README files too! |
BackEndTea
reviewed
Jul 22, 2019
BackEndTea
reviewed
Jul 22, 2019
Contributor
BackEndTea
left a comment
There was a problem hiding this comment.
Looks like this covers the polyfill almost perfectly.
It is probably nicer to add a README.md for this polyfill itself as well, in line with the other polyfills.
909d223 to
e039fce
Compare
IonBazan
commented
Jul 23, 2019
Contributor
Author
Member
nicolas-grekas
left a comment
There was a problem hiding this comment.
almost good to me thanks
aac8ed5 to
cac69ec
Compare
nicolas-grekas
approved these changes
Aug 1, 2019
Closed
Member
|
Thank you @IonBazan. |
nicolas-grekas
added a commit
that referenced
this pull request
Aug 6, 2019
This PR was squashed before being merged into the 1.11-dev branch (closes #181). Discussion ---------- add new PHP 7.4 functions This PR adds new PHP 7.4 functions: - [x] `get_mangled_object_vars` (php/php-src@eecd896) - [x] `mb_str_split` (https://wiki.php.net/rfc/mb_str_split) - [x] `password_algos` (https://wiki.php.net/rfc/password_registry) Closes #179 and replaces #178 Commits ------- 141689e add new PHP 7.4 functions
Contributor
|
FYI there has been multiple workarounds suggested on SO for https://stackoverflow.com/a/41664898/1839439 |
Member
|
@kamil-tekiela feel free to submit a PR! |
Contributor
|
Done #199 This is my first PR, so I am not sure I followed the process correctly or if my PR is useful at all. I appreciate feedback. |
glensc
reviewed
Jun 26, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds new PHP 7.4 functions:
get_mangled_object_vars(php/php-src@eecd896)mb_str_split(https://wiki.php.net/rfc/mb_str_split)password_algos(https://wiki.php.net/rfc/password_registry)Closes #179 and replaces #178