[make:entity] Autocompletion for enum classes#1785
Merged
GromNaN merged 14 commits intosymfony:1.xfrom Mar 16, 2026
Merged
Conversation
GromNaN
reviewed
Feb 23, 2026
Member
GromNaN
left a comment
There was a problem hiding this comment.
This feature is interesting, could you add some tests?
Contributor
Author
Resolved with aaa64b3 |
GromNaN
reviewed
Mar 11, 2026
Member
GromNaN
left a comment
There was a problem hiding this comment.
Great!
There are few adjustments to comply with our BC promise.
GromNaN
requested changes
Mar 11, 2026
GromNaN
reviewed
Mar 11, 2026
The MakerBundle is not registered in test environment in the tmp project
…the FileManager Make the class internal and remove the service definition
593aa48 to
56c662c
Compare
GromNaN
approved these changes
Mar 16, 2026
Member
GromNaN
left a comment
There was a problem hiding this comment.
The test failure is unrelated to this PR. It's caused by symfony/symfony#62967
Member
|
Thank you @tcoch. |
GromNaN
added a commit
that referenced
this pull request
Mar 17, 2026
(tcoch) This PR was squashed before being merged into the 1.x branch. Discussion ---------- Update Yaml indentation in tests after symfony/symfony#62967 symfony/symfony#62967 introduced a change in how YAML files are generated. For this reason, some tests are broken here (e.g. #1785). This PR aims to resolve that. The modifications are: - Test files used have been adapted towards the new format - Special case has been added to `YamlSourceManipulatorTest.php` to address specify of tests in this CI with PHP8.1 and SF6.4.* lowest deps Commits ------- ce97fb4 Update Yaml indentation in tests after symfony/symfony#62967
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to provide autocompletion for
enumclasses, just like it exists for doctrine relations.Two tests on generating entity with enum types already exist (https://github.com/symfony/maker-bundle/blob/1.x/tests/Maker/MakeEntityTest.php#L697-L741) to cover that this new feature won't break anything.