Add a dedicated file deletion for unconfigure recipes#667
Closed
maxhelias wants to merge 1 commit intosymfony:masterfrom
Closed
Add a dedicated file deletion for unconfigure recipes#667maxhelias wants to merge 1 commit intosymfony:masterfrom
maxhelias wants to merge 1 commit intosymfony:masterfrom
Conversation
3d1cd87 to
ba03b44
Compare
ba03b44 to
cf781bd
Compare
tgalopin
pushed a commit
to tgalopin/flex
that referenced
this pull request
Dec 3, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a first try for replace #615
In this way we a correct deletion of the same file imported by 2 recipes.
Factoring in this way would allow us to remove the
$lockparameter passing in theunconfiguremethod and with a little more work in theconfigure.WDYT @nicolas-grekas @weaverryan ?