Skip to content

only write lock when its content has changed#479

Merged
fabpot merged 1 commit intosymfony:masterfrom
stlrnz:lockfix
Mar 9, 2019
Merged

only write lock when its content has changed#479
fabpot merged 1 commit intosymfony:masterfrom
stlrnz:lockfix

Conversation

@stlrnz
Copy link
Copy Markdown
Contributor

@stlrnz stlrnz commented Mar 8, 2019

Fixed #379 by only writing the Lockfile when something has changed (which is not the case on composer install).

This seems to me the best solution for the linked issue:

  • no change in the Flex behaviour on composer install needed (still doing the same like on composer update)
  • only update the Lockfile when needed (even the modification timestamp will stay the same)
  • working for all composer actions (because of auto detection)

Thank you for your feedback.

@stlrnz
Copy link
Copy Markdown
Contributor Author

stlrnz commented Mar 8, 2019

Should I fix the coding standard issue (even it does not come from my changes)?

@fabpot
Copy link
Copy Markdown
Member

fabpot commented Mar 9, 2019

Thank you @stlrnz.

@fabpot fabpot merged commit ffe345f into symfony:master Mar 9, 2019
fabpot added a commit that referenced this pull request Mar 9, 2019
This PR was merged into the 1.2-dev branch.

Discussion
----------

only write lock when its content has changed

Fixed #379 by only writing the Lockfile when something has changed (which is not the case on `composer install`).

This seems to me the best solution for the linked issue:
* no change in the Flex behaviour on `composer install` needed (still doing the same like on `composer update`)
* only update the Lockfile when needed (even the modification timestamp will stay the same)
* working for all composer actions (because of auto detection)

Thank you for your feedback.

Commits
-------

ffe345f only write lock when its content has changed
nicolas-grekas added a commit that referenced this pull request Dec 13, 2019
This PR was squashed before being merged into the 1.5-dev branch.

Discussion
----------

compare data before marking lock as changed

In #479 I tried to fix the issue #379 by introducing a _changed_ flag to the Lock.

This patch worked for a few months. However, introducing #576 broke the patch by [always calling](https://github.com/symfony/flex/pull/576/files#diff-46b78198ae7ea525f04268205dd782c3R273) `set` ending in the same situation as before.

Blame on me for not checking if anything differs before setting the _changed_ flag. This PR tries to do better.

Commits
-------

bc400be compare data before marking lock as changed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants