Fix the build for WASI#916
Merged
Merged
Conversation
Contributor
Author
|
@swift-ci please test |
stephentyrone
approved these changes
Jan 17, 2025
|
Merging to unblock Swift CI. real fix coming by @grynspan i hear |
grynspan
added a commit
that referenced
this pull request
Jan 17, 2025
Thank you to @tshortli for the patch! We don't actually _need_ this property to be unavailable on WASI—it was just meant as a convenience. But since we're not using the property for anything at this time (a future PR might try to productize `TestContentRecord`), it's overkill. So instead I'll just leave the property available, and document it's always `nil` on statically-linked platforms.
grynspan
added a commit
that referenced
this pull request
Jan 17, 2025
Thank you to @tshortli for the patch! We don't actually _need_ this property to be unavailable on WASI—it was just meant as a convenience. But since we're not using the property for anything at this time (a future PR might try to productize `TestContentRecord`), it's overkill. So instead I'll just leave the property available, and document it's always `nil` on statically-linked platforms. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoids a compiler error when
SWT_NO_DYNAMIC_LINKINGis true.Motivation:
Fixes the broken build, which is blocking Swift compiler PR testing.
Modifications:
Makes
imageAddressa computed property whenSWT_NO_DYNAMIC_LINKINGis true so that it can be marked@available(*, unavailable).