Fix off-by-one error trimming barrier sequences from exit test output streams.#1694
Merged
Merged
Conversation
… streams. If the _only_ thing in the `stdout` or `stderr` stream of an exit test's child process is the barrier sequence (i.e. exactly those 32 bytes and nothing else), we fail to trim it off. Fix it. Resolves #1693.
dimitribouniol
approved these changes
Apr 28, 2026
dimitribouniol
left a comment
There was a problem hiding this comment.
Here's my emotional-support Approval 😛
stmontgomery
approved these changes
Apr 28, 2026
grynspan
added a commit
that referenced
this pull request
Apr 28, 2026
… streams. (#1694) If the _only_ thing in the `stdout` or `stderr` stream of an exit test's child process is the barrier sequence (i.e. exactly those 32 bytes and nothing else), we fail to trim it off. Fix it. Resolves #1693. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added a commit
that referenced
this pull request
Apr 28, 2026
…t output streams. (#1695) - **Explanation**: Fixes an off-by-one error that can corrupt output from exit tests. - **Scope**: Exit tests. - **Issues**: #1693 - **Original PRs**: #1694 - **Risk**: Low - **Testing**: New unit test. - **Reviewers**: @stmontgomery @dimitribouniol
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the only thing in the
stdoutorstderrstream of an exit test's child process is the barrier sequence (i.e. exactly those 32 bytes and nothing else), we fail to trim it off. Fix it.Resolves #1693.
Checklist: