Diagnose the use of a generic clause on @Test, @Suite, and @Tag.#1650
Merged
grynspan merged 2 commits intoApr 1, 2026
Conversation
For example: ```swift @test<[Int]>(arguments: [1, 2, 3]) func f(i: Int) { ... } ``` We never intended for this to be valid syntax. It appears some folks _are_ using it, so deprecate for now and make it an error in the next language mode.
harlanhaskins
approved these changes
Mar 31, 2026
stmontgomery
approved these changes
Apr 1, 2026
grynspan
added a commit
that referenced
this pull request
Apr 1, 2026
#1650) For example: ```swift @test<[Int]>(arguments: [1, 2, 3]) func f(i: Int) { ... } ``` We never intended for this to be valid syntax. It appears some folks _are_ using it, so deprecate for now and make it an error in the next language mode. The diagnostic looks like this in the Swift 6 language mode: >⚠️ Generic argument clause of attribute 'Test' is unsupported; this is an error in the Swift 7 language mode And in the Swift 7 language mode, it's an error. (In the future, if we find that this syntax is useful and want to build out some sort of support for it, we can of course remove the diagnostic.) ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated.
grynspan
added a commit
that referenced
this pull request
Apr 1, 2026
…d `@Tag`. (#1653) - **Explanation**: Disallow (warn) the use of the generic clause syntax on our attribute macros as we never intended for them to work and they are not handled by the macro expansions. - **Scope**: Macro expansion - **Issues**: N/A - **Original PRs**: #1650 - **Risk**: Low (adds a warning) - **Testing**: New unit test - **Reviewers**: @stmontgomery @harlanhaskins
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For example:
We never intended for this to be valid syntax. It appears some folks are using it, so deprecate for now and make it an error in the next language mode. The diagnostic looks like this in the Swift 6 language mode:
And in the Swift 7 language mode, it's an error. (In the future, if we find that this syntax is useful and want to build out some sort of support for it, we can of course remove the diagnostic.)
Checklist: