Fully-qualify reference to 'Comment' type in #expect expansion when comment argument isn't a string literal#1645
Merged
Conversation
…omment argument isn't a string literal Fixes swiftlang#1641
grynspan
approved these changes
Mar 31, 2026
stmontgomery
added a commit
that referenced
this pull request
Apr 1, 2026
…n when comment argument isn't a string literal (#1648) - **Explanation**: This fixes a build error which can arise in the code emitted by `#expect` when the `comment` argument is not a string literal and the module the `#expect` appears in has a custom type visible named `Comment`, conflicting with the testing library's built-in type by that name. - **Scope**: Affects a narrow use case of expectations: those which include custom comment arguments which aren't string literals - **Issues**: #1641 - **Original PRs**: #1645 - **Risk**: Low; affects a corner case in the expansion of `#expect` and `#require` macros - **Testing**: Added a new regression test - **Reviewers**: @grynspan
stmontgomery
added a commit
that referenced
this pull request
Apr 1, 2026
…when comment argument isn't a string literal (#1652) - **Explanation**: This fixes a build error which can arise in the code emitted by `#expect` when the `comment` argument is not a string literal and the module the `#expect` appears in has a custom type visible named `Comment`, conflicting with the testing library's built-in type by that name. - **Scope**: Affects a narrow use case of expectations: those which include custom comment arguments which aren't string literals - **Issues**: #1641 - **Original PRs**: #1645 - **Risk**: Low; affects a corner case in the expansion of `#expect` and `#require` macros - **Testing**: Added a new regression test - **Reviewers**: @grynspan
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a build error which can arise in the code emitted by
#expectwhen thecommentargument is not a string literal and the module the#expectappears in has a custom type visible namedComment, conflicting with the testing library's built-in type by that name.Fixes #1641
Checklist: