Include severity and isFailure for Issues in the published JSON event stream#1279
Merged
Merged
Conversation
Contributor
Author
|
@swift-ci test |
grynspan
reviewed
Aug 20, 2025
grynspan
reviewed
Aug 20, 2025
| await test.run(configuration: configuration) | ||
| } | ||
|
|
||
| let decodedRecords = try FileHandle(forReadingAtPath: temporaryFilePath).readToEnd() |
Contributor
There was a problem hiding this comment.
I assume this was copied from another test; should we factor it into a helper?
Contributor
Author
There was a problem hiding this comment.
Added helpers a helper to wrap the common behaviour for reading and deserialising ABI.Record JSON from a file. Take a look and let me know what you think.
If we're looking to do more testing on the event stream longer term, it might make sense to create some sort of EventStreamFile object to make it slightly easier to work with arrays of ABI.Record. In particular, we do a lot of filtering on Record.kind which is a little awkward since it's an enum with an associated value.
I'm not doing that in this change to keep it more lightweight, but wanted to bring that up as a possible future direction.
grynspan
approved these changes
Aug 20, 2025
Contributor
Author
|
@swift-ci test |
stmontgomery
approved these changes
Aug 21, 2025
… stream ### Motivation: - Proposed and accepted in ST-0013 [^1], so we can move ahead and include this in the event stream. - This will _not_ be available in event stream version 0 as this is considered a breaking change [^2] ### Modifications: - Promote existing _severity/_isFailure fields -> severity/isFailure without the underscores This effectively makes them part of the official JSON ABI. The underscored names will no longer be accessible, but they were always experimental so this is not considered a blocker. - Only emit severity/isFailure when using event stream version >= 6.3 This removes access to the underscored names from earlier versions, but again, these were experimental. - Remove hidden __CommandLineArguments_v0 argument isWarningIssueRecordedEventEnabled This was only for internal testing use, but is obsolete because we test issue severity by specifying event stream version >= 6.3. ### Checklist: - [x] Code and documentation should follow the style of the [Style Guide](https://github.com/apple/swift-testing/blob/main/Documentation/StyleGuide.md). - [x] If public symbols are renamed or modified, DocC references should be updated. [^1]: https://github.com/swiftlang/swift-evolution/blob/main/proposals/testing/0013-issue-severity-warning.md [^2]: https://github.com/swiftlang/swift-evolution/blob/main/proposals/testing/0013-issue-severity-warning.md#integration-with-supporting-tools # Conflicts: # Sources/Testing/ABI/EntryPoints/EntryPoint.swift
0a07bd8 to
64505c3
Compare
plemarquand
added a commit
to plemarquand/vscode-swift
that referenced
this pull request
Sep 2, 2025
Add support for swift-testing issue severity, added in swiftlang/swift-testing#1279 If an issue is recorded with a severity that does not meet the threshold for a failure then don't record the issue.
3 tasks
plemarquand
added a commit
to swiftlang/vscode-swift
that referenced
this pull request
Sep 4, 2025
Add support for swift-testing issue severity, added in swiftlang/swift-testing#1279 If an issue is recorded with a severity that does not meet the threshold for a failure then don't record the issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
Proposed and accepted in ST-0013 1, so we can move ahead and include this in the event stream.
This will not be available in event stream version 0 as this is considered a breaking change 2
Modifications:
Promote existing _severity/_isFailure fields -> severity/isFailure without the underscores
This effectively makes them part of the official JSON ABI. The underscored names will no longer be accessible, but they were always experimental so this is not considered a blocker.
Only emit severity/isFailure when using event stream version >= 6.3
This removes access to the underscored names from earlier versions, but again, these were experimental.
Remove hidden
__CommandLineArguments_v0argumentisWarningIssueRecordedEventEnabledThis was only for internal testing use, but is obsolete because we test issue severity by specifying event stream version >= 6.3.
Checklist:
Fixes rdar://158621033
Footnotes
https://github.com/swiftlang/swift-evolution/blob/main/proposals/testing/0013-issue-severity-warning.md ↩
https://github.com/swiftlang/swift-evolution/blob/main/proposals/testing/0013-issue-severity-warning.md#integration-with-supporting-tools ↩