Skip to content

Allow ByteTree deserialisation functions to throw#2

Merged
nkcsgexi merged 1 commit intoswiftlang:masterfrom
ahoppen:throwing-decoding
Sep 11, 2018
Merged

Allow ByteTree deserialisation functions to throw#2
nkcsgexi merged 1 commit intoswiftlang:masterfrom
ahoppen:throwing-decoding

Conversation

@ahoppen
Copy link
Copy Markdown
Member

@ahoppen ahoppen commented Aug 30, 2018

At the moment we fatalError if an error occurs while deserialising ByteTree (e.g. because of an unexpected syntax node kind or because incremental parsing failed. With this, we will throw and the client will be able to handle the error.

@rintaro
Copy link
Copy Markdown
Member

rintaro commented Sep 11, 2018

@nkcsgexi nkcsgexi merged commit 239c66a into swiftlang:master Sep 11, 2018
@ahoppen ahoppen deleted the throwing-decoding branch September 12, 2018 07:26
CippoX added a commit to CippoX/swift-syntax that referenced this pull request Mar 21, 2023
# This is the 1st commit message:

fixed testAvailabilityQuery34 and testAvailabilityQueryUnavailability28

# This is the commit message swiftlang#2:

Update Sources/SwiftParserDiagnostics/ParseDiagnosticsGenerator.swift

Co-authored-by: Kim de Vos <kimdevos12@hotmail.com>
# This is the commit message swiftlang#3:

added fixedSource in test case

# This is the commit message swiftlang#4:

minor changes

# This is the commit message swiftlang#5:

implemented recovery inside the parser

# This is the commit message swiftlang#6:

runned format.py

# This is the commit message swiftlang#7:

minor changes

# This is the commit message swiftlang#8:

minor changes
adevress pushed a commit to adevress/swift-syntax that referenced this pull request Jan 14, 2024
Remove extra space for closures with captures but no arguments.
kateinoigakukun pushed a commit to kateinoigakukun/swift-syntax that referenced this pull request Feb 27, 2024
xedin added a commit to xedin/swift-syntax that referenced this pull request Aug 13, 2025
…ly accessible

In it's current state `AddPackageTarget` does multiple things:

1. Updates the manifest to introduce new targets and dependencies.

2. Generates one or more auxiliary files depending on the type of
target being added (i.e. a primary file for the target and sometimes
a macro specific defintions file).

We'd like to scope the refactoring action down to manifest updates only.

The callers are going to be resposble for swiftlang#2 from the list. In order to
do that `PackageTarget.sanitizedName` and `PackageTarget.Dependency.name`
have to be externally accessible (under `@_spi(PackageRefactor)` still)
to form the content of the file.
xedin added a commit to xedin/swift-syntax that referenced this pull request Aug 13, 2025
…ly accessible

In it's current state `AddPackageTarget` does multiple things:

1. Updates the manifest to introduce new targets and dependencies.

2. Generates one or more auxiliary files depending on the type of
target being added (i.e. a primary file for the target and sometimes
a macro specific defintions file).

We'd like to scope the refactoring action down to manifest updates only.

The callers are going to be resposble for swiftlang#2 from the list. In order to
do that `PackageTarget.sanitizedName` and `PackageTarget.Dependency.name`
have to be externally accessible (under `@_spi(PackageRefactor)` still)
to form the content of the file.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants