Skip to content

Tests: Migrate PackageCommandTests to Swift Testing and Augment#9012

Merged
bkhouri merged 1 commit into
swiftlang:mainfrom
bkhouri:t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST
Aug 21, 2025
Merged

Tests: Migrate PackageCommandTests to Swift Testing and Augment#9012
bkhouri merged 1 commit into
swiftlang:mainfrom
bkhouri:t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST

Conversation

@bkhouri

@bkhouri bkhouri commented Aug 11, 2025

Copy link
Copy Markdown
Contributor

Migrate the PackageCommandTests to Swift Testing and augment the suite to run against the Native and SwiftBuild build system, in addition to the debug and release build configurations.

Depends on: #9020
Relates to: #8997
issue: rdar://157669245

@bkhouri

bkhouri commented Aug 11, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 11, 2025
Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment
the test to run against both the Native and SwiftBUild build system, in
addition to the `debug`` and `release` build configuration.

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
}
}
} when: {
(ProcessInfo.hostOperatingSystem == .windows && data.buildSystem == .swiftbuild && !withPrettyPrinting)

@cmcgee1024 cmcgee1024 Aug 12, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggestion (non-blocking): The known issue is with windows and the swiftbuild build system. I expect that the pretty printing doesn't impact this check at all, so I would remove the check whether pretty printing is not enabled.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This matches the XCTest version of the test.

bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 12, 2025
Migrate a few suites to Swift Teting, namely,
  - SwiftSDKCommandTests
  - MultiRootSupportTests
  - SwiftCommandStateTests

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 12, 2025
Migrate a few suites to Swift Teting, namely,
  - SwiftSDKCommandTests
  - MultiRootSupportTests
  - SwiftCommandStateTests

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from 37217a5 to d505742 Compare August 12, 2025 17:50
@bkhouri

bkhouri commented Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from d505742 to 0e692c0 Compare August 13, 2025 18:44
@bkhouri

bkhouri commented Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@bkhouri

bkhouri commented Aug 13, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test windows

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from 0e692c0 to 5ce19cf Compare August 14, 2025 16:05
@bkhouri

bkhouri commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@bkhouri

bkhouri commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test windows

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from 5ce19cf to f2c5311 Compare August 14, 2025 19:19
@bkhouri

bkhouri commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@bkhouri

bkhouri commented Aug 14, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test windows

@bkhouri

bkhouri commented Aug 17, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@bkhouri bkhouri force-pushed the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch from f2c5311 to aace277 Compare August 18, 2025 14:10
@bkhouri

bkhouri commented Aug 18, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@bkhouri bkhouri marked this pull request as ready for review August 18, 2025 14:10
@bkhouri

bkhouri commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test

@bkhouri

bkhouri commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test windows

@bkhouri

bkhouri commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test macOS

@bkhouri

bkhouri commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

the macOS platform smoke test CI build failed unrelated to the change

14:18:26  + /usr/local/bin/sccache --stop-server
14:18:26  Stopping sccache server...
14:18:29  Cannot contact macos-node-i-054857cebc3a89e32: java.io.IOException: cannot find current thread
14:23:56  Cancelling nested steps due to timeout
14:23:56  Sending interrupt signal to process

Re-triggering the macOS pipelines

@swift-ci smoke test macOS platform

@cachemeifyoucan

Copy link
Copy Markdown
Contributor

@swift-ci smoke test macOS platform

@cachemeifyoucan

Copy link
Copy Markdown
Contributor

@swift-ci smoketest macOS platform

@bkhouri

bkhouri commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

The macOS self hosted pipeline failed at the threadSafeBox test timed out. This is being addressed in #9045.
The macOS Platform test (smoke test) failed for an infrastructure issue, where sccache failed to stop

15:58:21  + /usr/local/bin/sccache --stop-server
15:58:21  Stopping sccache server...
15:58:24  Cannot contact macos-node-i-054857cebc3a89e32: java.io.IOException: cannot find current thread
16:03:51  Cancelling nested steps due to timeout
16:03:51  Sending interrupt signal to process
16:03:58  /Users/ec2-user/jenkins/workspace/swift-package-manager-PR-macos-smoke-test@tmp/durable-af179483/script.sh.copy: line 1: 59529 Terminated: 15          /usr/local/bin/sccache --stop-server

Re-triggering macOS builds

@swift-ci test macOS

@bkhouri

bkhouri commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test self hosted macos

@bkhouri

bkhouri commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test self hosted

@bkhouri bkhouri enabled auto-merge (squash) August 20, 2025 16:55
@bkhouri

bkhouri commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

The windows self hosted pipeline has been running for over 3 hours. Let's re-trigger the build

@swift-ci test self hosted windows

bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 20, 2025
Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment
the test to run against both the Native and SwiftBUild build system, in
addition to the `debug`` and `release` build configuration.

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
@bkhouri

bkhouri commented Aug 20, 2025

Copy link
Copy Markdown
Contributor Author

@swift-ci test self hosted windows

@bkhouri

bkhouri commented Aug 21, 2025

Copy link
Copy Markdown
Contributor Author

Windows self hosted failed due to a test failure

18:51:59  × Test completionToolListExecutables(data:) recorded an issue with 1 argument data → BuildData(buildSystem: SPMBuildCore.BuildSystemProvider.Kind.native, config: PackageModel.BuildConfiguration.release) at PackageCommandTests.swift:1171:17: Expectation failed: (result.stdout → "") == ("exec1\nexec2\n" → "exec1

18:51:59  exec2

18:51:59  ")

re-triggering to determine the occurrence

@swift-ci test self hosted windows

@bkhouri bkhouri merged commit f042205 into swiftlang:main Aug 21, 2025
6 checks passed
@bkhouri bkhouri deleted the t/main/gh8997_rdar157669245_migrate-packacage_command_tests_to_ST branch August 21, 2025 17:02
bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 21, 2025
Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment
the test to run against both the Native and SwiftBUild build system, in
addition to the `debug`` and `release` build configuration.

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 21, 2025
Migrate a few suites to Swift Teting, namely,
  - SwiftSDKCommandTests
  - MultiRootSupportTests

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 21, 2025
Migrate a few suites to Swift Teting, namely,
  - SwiftSDKCommandTests
  - MultiRootSupportTests

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 29, 2025
Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment
the test to run against both the Native and SwiftBUild build system, in
addition to the `debug`` and `release` build configuration.

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 29, 2025
Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment
the test to run against both the Native and SwiftBUild build system, in
addition to the `debug`` and `release` build configuration.

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 29, 2025
Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment
the test to run against both the Native and SwiftBUild build system, in
addition to the `debug`` and `release` build configuration.

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
bkhouri added a commit to bkhouri/swift-package-manager that referenced this pull request Aug 29, 2025
Migrate a few suites to Swift Teting, namely,
  - SwiftSDKCommandTests
  - MultiRootSupportTests

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
bkhouri added a commit that referenced this pull request Sep 2, 2025
Migrate a few suites to Swift Teting, namely,
  - SwiftSDKCommandTests
  - MultiRootSupportTests

Depends on: #9012
Relates to: #8997
issue: rdar://157669245
bkhouri added a commit that referenced this pull request Sep 2, 2025
…9013)

Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment
the test to run against both the Native and SwiftBUild build system, in
addition to the `debug` and `release` build configuration.

Depends on: #9012
Relates to: #8997
issue: rdar://157669245
johnbute pushed a commit to johnbute/fork-swift-package-manager that referenced this pull request Oct 2, 2025
Migrate a few suites to Swift Teting, namely,
  - SwiftSDKCommandTests
  - MultiRootSupportTests

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
johnbute pushed a commit to johnbute/fork-swift-package-manager that referenced this pull request Oct 2, 2025
…wiftlang#9013)

Migrate the `BuildSystemDelegateTests` test to Swift Testing and augment
the test to run against both the Native and SwiftBUild build system, in
addition to the `debug` and `release` build configuration.

Depends on: swiftlang#9012
Relates to: swiftlang#8997
issue: rdar://157669245
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants