Add an Environment type to represent environment variables#298
Merged
jakepetroules merged 1 commit intomainfrom Mar 13, 2025
Merged
Add an Environment type to represent environment variables#298jakepetroules merged 1 commit intomainfrom
jakepetroules merged 1 commit intomainfrom
Conversation
Collaborator
Author
|
@swift-ci test |
jakepetroules
commented
Mar 12, 2025
Sources/SWBUtil/Environment.swift
Outdated
Collaborator
Author
There was a problem hiding this comment.
Ignore the "diffs" in this file. This PR is entirely additions; the original Environment.swift was renamed to EnvironmentHelpers.swift.
neonichu
approved these changes
Mar 12, 2025
Collaborator
Author
|
@swift-ci test windows |
Collaborator
Author
|
@swift-ci test |
Collaborator
Author
|
@swift-ci test windows |
Member
|
If you want to apply it somewhere, TouchTool could use some love. |
Collaborator
Author
|
@swift-ci test |
1 similar comment
Collaborator
Author
|
@swift-ci test |
This starts with a slightly modified version of the implementation from SwiftPM. This is not yet adopted anywhere, it's just adding the initial implementation. Closes #186
Collaborator
Author
|
@swift-ci test |
Collaborator
Author
Coming in a follow-on PR :) |
Member
|
@jakepetroules I am afraid your last patch causes a compile failure on Windows: Attaching the full lo here: swift-main-windows-toolchain-arm64-1060.log As a result the nightly builds fail and PR testing is stuck. I will prepare a revert. Please let me know if you have a better proposal. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This starts with a slightly modified version of the implementation from SwiftPM. This is not yet adopted anywhere, it's just adding the initial implementation.
Closes #186