Skip to content

Fix test target compilation for WebAssembly#1348

Merged
owenv merged 1 commit into
swiftlang:mainfrom
owenv:owenv/wasmtests
Apr 28, 2026
Merged

Fix test target compilation for WebAssembly#1348
owenv merged 1 commit into
swiftlang:mainfrom
owenv:owenv/wasmtests

Conversation

@owenv

@owenv owenv commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator
  • Build test targets as static archives when targeting WebAssembly
  • Ensure test runners use --whole-archive when incorporating static archives so we don't drop swift-testing tests
  • Refactor handling of search paths vs direct inputs when constructing archiver arguments
  • Fix an issue where the generic unix test product type wasn't setting ENABLE_TESTING_SEARCH_PATHS correctly

@owenv

owenv commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator Author

@swift-ci test

@owenv owenv force-pushed the owenv/wasmtests branch from 9d88620 to a939a09 Compare April 28, 2026 00:53
@owenv

owenv commented Apr 28, 2026

Copy link
Copy Markdown
Collaborator Author

@swift-ci test

@owenv owenv mentioned this pull request Apr 28, 2026
Draft
@artemcm artemcm mentioned this pull request Apr 28, 2026
Merged
@owenv owenv merged commit d5c113f into swiftlang:main Apr 28, 2026
123 of 126 checks passed
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request Apr 29, 2026
@jakepetroules
Change default Android SDK build command
95e2a7f 
Updated default build command for Android SDK to use 'swift build' instead of 'swift build --build-system native'.

The 4/27 snapshot contains the requisite changes for Android to work.

For Wasm, we want to wait until swiftlang/swift-build#1348 lands before unpinning.
@jakepetroules jakepetroules mentioned this pull request Apr 29, 2026
Merged
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request Apr 29, 2026
@jakepetroules
Change default Android SDK build command
2a7f6c8 
Updated default build command for Android SDK to use 'swift build' instead of 'swift build --build-system native'.

The 4/27 snapshot contains the requisite changes for Android to work.

For Wasm, we want to wait until swiftlang/swift-build#1348 lands before unpinning.
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request Apr 29, 2026
@jakepetroules
Change default Android SDK build command
84a0e37 
Updated default build command for Android SDK to use 'swift build' instead of 'swift build --build-system native'.

The 4/27 snapshot contains the requisite changes for Android to work.

For Wasm, we want to wait until swiftlang/swift-build#1348 lands before unpinning.
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request Apr 29, 2026
@jakepetroules
Change default Android SDK build command
fb98750 
Updated default build command for Android SDK to use 'swift build' instead of 'swift build --build-system native'.

The 4/27 snapshot contains the requisite changes for Android to work.

For Wasm, we want to wait until swiftlang/swift-build#1348 lands before unpinning.
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request Apr 29, 2026
@jakepetroules
Change default Android SDK build command
11f9ecf 
Updated default build command for Android SDK to use 'swift build' instead of 'swift build --build-system native'.

The 4/27 snapshot contains the requisite changes for Android to work.

For Wasm, we want to wait until swiftlang/swift-build#1348 lands before unpinning.
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request Apr 30, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
4703b3b 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 1, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
89ee068 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 1, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
26548d7 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
b322c51 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
1a970c7 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
0bbde38 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
aa8b85a 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
6c3388d 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
0bd041a 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
d47ca32 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
4ad6971 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
a53bda3 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
50ba6c2 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
6eb6d0c 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
21be017 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
23a32b9 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
0515f5e 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
4ffd4c5 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
5742b2a 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
jakepetroules added a commit to jakepetroules/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration
e85b596 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
justice-adams-apple pushed a commit to swiftlang/github-workflows that referenced this pull request May 12, 2026
@jakepetroules @marcprux
Improve Android SDK build configuration (#269)
a3aac61 
- Change default build command to use 'swift build' instead of
  'swift build --build-system native' (the 4/27 snapshot contains
  the requisite changes for Android)
- Use the correct host toolchain for Android build/test
- Add mention of the specific host SDK being used to build

For Wasm, we want to wait until
swiftlang/swift-build#1348 lands before
unpinning.

Co-authored-by: Marc Prud'hommeaux <mwp1@cornell.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jakepetroules jakepetroules jakepetroules approved these changes

@aciidgh aciidgh Awaiting requested review from aciidgh aciidgh is a code owner

@mhrawdon mhrawdon Awaiting requested review from mhrawdon mhrawdon is a code owner

@neonichu neonichu Awaiting requested review from neonichu neonichu is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@owenv @jakepetroules