[build] Make the new --cross-compile-build-swift-tools flag public#83422
[build] Make the new --cross-compile-build-swift-tools flag public#83422finagolfin merged 1 commit intoswiftlang:mainfrom
--cross-compile-build-swift-tools flag public#83422Conversation
|
@swift-ci smoke test |
|
@swift-ci smoke test |
|
Added a validation test and rebased @swift-ci smoke test linux |
|
@swift-ci smoke test macos |
There was a problem hiding this comment.
@artemcm, these build system tests were disabled on remote CI like iOS or Android two years ago, which is why I can remove these then redundant lines in this single test, but you disabled xros after that lit.local.cfg was added: are these tests being run natively on xros, so I need to keep this test disabled there?
There was a problem hiding this comment.
Never mind, looks like these are still run for the iPhone simulator, so reverting this change of platforms for this one test.
489845a to
47815fd
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test macos |
|
@swift-ci smoke test macos |
|
@swift-ci smoke test macos |
|
@swift-ci smoke test linux |
|
@swift-ci smoke test windows |
This new flag makes it easy to build Swift cross-compilation toolchains, by disabling cross-compilation of all host tools, like the Swift compiler and various macros, building on prior pulls swiftlang#38441 and swiftlang#82163. Also, add two class methods to the Testing macros product so it works with swiftlang#83260.
|
@swift-ci test |
|
@edymtt, would you review? |
|
@kateinoigakukun, maybe you can take a look, since you may have made similar changes for Wasm, like not cross-compiling the Foundation and Testing macros. |
|
Thanks, Yuta, merging since this is all gated by a new flag, so it won't break anything, and I want to get it into 6.2 next. |
I missed that `build-script` passes back `false` instead, so use the `true_false` function for broader checking.
I missed that `build-script` passes back `false` instead, so use the `true_false` function for broader checking.
This new flag makes it easy to build Swift cross-compilation toolchains, by disabling cross-compilation of all host tools, like the Swift compiler and various macros, building on prior pulls #38441 and #82163.
Native compilation has more fine-grained flags like
--build-swift-tools,--build-llvm, and--swift-testing-macros, but those will disable building them for all platforms (with the exception of--build-swift-tools, which I modified to only apply for the host, since the initial introduction of this--cross-compile-build-swift-toolsflag a couple months ago), so they're not suited for building a cross-compilation toolchain, where you want all host tools built for the native host but not for any cross-compilation SDKs.