[test] Fix IRGen/framepointer.sil for the test-simulator CI#81643
Merged
finagolfin merged 1 commit intoswiftlang:mainfrom May 20, 2025
Merged
[test] Fix IRGen/framepointer.sil for the test-simulator CI#81643finagolfin merged 1 commit intoswiftlang:mainfrom
finagolfin merged 1 commit intoswiftlang:mainfrom
Conversation
which generates IR without a llvm.trap function
Member
Author
|
@swift-ci smoke test |
tbkka
pushed a commit
that referenced
this pull request
Jun 23, 2025
which generates IR without a llvm.trap function All the normal CI generated this: ``` ret i32 %1 } ; Function Attrs: cold noreturn nounwind memory(inaccessiblemem: write) declare void @llvm.trap() #1 attributes #0 = { "frame-pointer"= ``` But the test-simulator CI doesn't for some reason, so just check for the closing brace instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
which generates IR without a llvm.trap function
All the normal CI generated this:
But the test-simulator CI doesn't for some reason, so just check for the closing brace instead.
@aschwaighofer, let me know what you think.