[5.8] don't assert when a module re-exports a module and one of its symbols#64480
Merged
airspeedswift merged 1 commit intorelease/5.8from Mar 22, 2023
Merged
Conversation
Contributor
Author
|
@swift-ci Please test |
xymus
approved these changes
Mar 21, 2023
Contributor
xymus
left a comment
There was a problem hiding this comment.
This looks good!
Qualified reexport has caused us other problems recently at the lookup level. It was interesting to see it being supported by collectParsedExportedSymbols. Did you notice other logic specifically to deal with qualified reexports elsewhere in the compiler by chance?
artemcm
approved these changes
Mar 21, 2023
Contributor
artemcm
left a comment
There was a problem hiding this comment.
This fix looks very reasonable to me!
Contributor
Author
|
@xymus I'm not sure about other places in the compiler; |
airspeedswift
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves rdar://106807038
Cherry-pick of #64479 to
release/5.8to fix Linux builds for situations mentioned in the other PR, since Linux builds of the compiler keep assertions enabled.