don't assert when a module re-exports a module and one of its symbols#64479
Merged
QuietMisdreavus merged 1 commit intomainfrom Mar 22, 2023
Merged
don't assert when a module re-exports a module and one of its symbols#64479QuietMisdreavus merged 1 commit intomainfrom
QuietMisdreavus merged 1 commit intomainfrom
Conversation
Contributor
Author
|
@swift-ci Please smoke test |
Contributor
Author
|
I double-checked the symbol graph generated by Swift 5.7.2 (in Xcode 14.2) in macOS where assertions were disabled, and it seems like the "duplicate" symbols were already being filtered out by SymbolGraphGen's use of a |
artemcm
approved these changes
Mar 21, 2023
Contributor
artemcm
left a comment
There was a problem hiding this comment.
This seems like a reasonable change to me.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves rdar://106807038
SymbolGraphGen currently asserts if a module includes re-exports like the following:
This is because there's a validity check in the code that handles re-exports to ensure that duplicate symbol data does not end up in the symbol graph. However, this is valid Swift and should be treated as such.
This PR updates the exported-import handler to skip qualified re-exports that come from a module that is also being re-exported as a whole. The qualified symbol in question should already be counted because it is in the module being blanket exported.