Add arm64 -> arm64e fallback to module loading#39083
Merged
beccadax merged 2 commits intoswiftlang:mainfrom Sep 10, 2021
Merged
Add arm64 -> arm64e fallback to module loading#39083beccadax merged 2 commits intoswiftlang:mainfrom
beccadax merged 2 commits intoswiftlang:mainfrom
Conversation
DummyFramework.framework has two different properties to support two different kinds of test cases: to support ModuleInterface/build-alternative-interface-framework.swift, its macOS interfaces are broken, but to support ModuleInterface/arm64e-fallback.swift, it supports only arm64, not arm64e, on iOS. The arm64e test's behavior is about to change, which will complicate all of this. As a preliminary step, make the two tests use two different frameworks so they aren't so intertwined. This temporarily keeps the arm64e test using the name "DummyFramework", but that will change.
Contributor
Author
|
@swift-ci please test |
beccadax
commented
Aug 27, 2021
Contributor
Author
|
@nkcsgexi I'm hoping you can confirm that my changes to ModuleInterface/build-alternative-interface-framework.swift are correct. @varungandhi-apple I'm hoping you can confirm that we're testing what we want to test with regards to arm64e. |
5 tasks
If we are building for ARM64 but we try to import a module with only an ARM64e interface, fall back to importing said interface. This is the reverse of a similar fallback briefly introduced last year, but removed in swiftlang#31196.
4e056d7 to
2240a39
Compare
varungandhi-apple
approved these changes
Sep 7, 2021
Contributor
varungandhi-apple
left a comment
There was a problem hiding this comment.
The testing bit LGTM. 👍🏼
nkcsgexi
approved these changes
Sep 7, 2021
Contributor
Author
|
@swift-ci smoke test |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If we are building for ARM64 but we try to import a module with only an ARM64e interface, fall back to importing said interface.
This is the reverse of a similar fallback briefly introduced last year, but removed in #31196.
rdar://82362695