Remove fallback for arm64e -> arm64.#31196
Merged
varungandhi-apple merged 3 commits intoswiftlang:masterfrom Apr 23, 2020
Merged
Remove fallback for arm64e -> arm64.#31196varungandhi-apple merged 3 commits intoswiftlang:masterfrom
varungandhi-apple merged 3 commits intoswiftlang:masterfrom
Conversation
Contributor
Author
|
@swift-ci please smoke test |
beccadax
requested changes
Apr 22, 2020
Contributor
beccadax
left a comment
There was a problem hiding this comment.
Might not actually need any changes—take a look.
...face/Inputs/DummyFramework.framework/Modules/DummyFramework.swiftmodule/arm64.swiftinterface
Outdated
Show resolved
Hide resolved
Contributor
Author
I don't get it. This branch shouldn't be present, should it? I've removed it in the middle commit. |
b78f5d0 to
94eed0e
Compare
Contributor
Author
|
@swift-ci please smoke test |
94eed0e to
9f3ba78
Compare
Addresses rdar://problem/61407215.
beccadax
approved these changes
Apr 23, 2020
…g arch. Before this change, we would emit the warning only for swiftmodules; however, it may be the case that only a swiftinterface (of a different arch) is present but no swiftmodule is present. Fixes rdar://problem/50905075.
9f3ba78 to
412ee0a
Compare
Contributor
Author
|
@swift-ci please smoke test |
This was referenced Apr 24, 2020
beccadax
added a commit
to beccadax/swift
that referenced
this pull request
Sep 7, 2021
If we are building for ARM64 but we try to import a module with only an ARM64e interface, fall back to importing said interface. This is the reverse of a similar fallback briefly introduced last year, but removed in swiftlang#31196.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes rdar://problem/61407215